Tarantool development patches archive
 help / color / mirror / Atom feed
From: Roman Khabibov <roman.habibov@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v4 0/5] Support column addition
Date: Fri,  9 Oct 2020 16:45:24 +0300	[thread overview]
Message-ID: <20201009134529.13212-1-roman.habibov@tarantool.org> (raw)

I alreday have LGTM from Vlad.
About non empty spaces: https://github.com/tarantool/tarantool/issues/5405

Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3075-add-column-v2
Issues: https://github.com/tarantool/tarantool/issues/2349 and
       https://github.com/tarantool/tarantool/issues/3075

@ChangeLog
* Support <ALTER TABLE ADD COLUMN> statement (gh-3075).

Roman Khabibov (5):
  sql: rename TK_COLUMN to TK_COLUMN_REF
  sql: refactor create_table_def and parse
  schema: add box_space_field_MAX
  sql: use parser's region of "index" array
  sql: support column addition

 extra/addopcodes.sh            |   2 +-
 extra/mkkeywordhash.c          |   7 +-
 src/box/errcode.h              |   2 +
 src/box/schema_def.h           |   1 +
 src/box/sql/build.c            | 617 +++++++++++++++++++++++----------
 src/box/sql/expr.c             |  48 +--
 src/box/sql/fk_constraint.c    |   2 +-
 src/box/sql/parse.y            |  48 ++-
 src/box/sql/parse_def.h        |  83 +++--
 src/box/sql/prepare.c          |   3 +-
 src/box/sql/resolve.c          |  10 +-
 src/box/sql/select.c           |  10 +-
 src/box/sql/sqlInt.h           |  59 +++-
 src/box/sql/tokenize.c         |  17 +-
 src/box/sql/treeview.c         |   2 +-
 src/box/sql/where.c            |  18 +-
 src/box/sql/whereexpr.c        |  12 +-
 test/box/error.result          |   1 +
 test/sql/add-column.result     | 529 ++++++++++++++++++++++++++++
 test/sql/add-column.test.sql   | 183 ++++++++++
 test/sql/checks.result         |  20 ++
 test/sql/checks.test.lua       |   9 +
 test/sql/foreign-keys.result   |  28 ++
 test/sql/foreign-keys.test.lua |  11 +
 24 files changed, 1426 insertions(+), 296 deletions(-)
 create mode 100644 test/sql/add-column.result
 create mode 100644 test/sql/add-column.test.sql

-- 
2.24.3 (Apple Git-128)

             reply	other threads:[~2020-10-09 13:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09 13:45 Roman Khabibov [this message]
2020-10-09 13:45 ` [Tarantool-patches] [PATCH v4 1/5] sql: rename TK_COLUMN to TK_COLUMN_REF Roman Khabibov
2020-11-05 22:17   ` Nikita Pettik
2020-10-09 13:45 ` [Tarantool-patches] [PATCH v4 2/5] sql: refactor create_table_def and parse Roman Khabibov
2020-11-05 22:17   ` Nikita Pettik
2020-11-10 12:17     ` Roman Khabibov
2020-11-17 20:23       ` Nikita Pettik
2020-11-15 11:51         ` roman
2020-10-09 13:45 ` [Tarantool-patches] [PATCH v4 3/5] schema: add box_space_field_MAX Roman Khabibov
2020-11-05 22:18   ` Nikita Pettik
2020-10-09 13:45 ` [Tarantool-patches] [PATCH v4 4/5] sql: use parser's region of "index" array Roman Khabibov
2020-11-05 22:26   ` Nikita Pettik
2020-11-10 12:18     ` Roman Khabibov
2020-11-17 20:35       ` Nikita Pettik
     [not found] ` <20201009134529.13212-6-roman.habibov@tarantool.org>
2020-11-06 15:57   ` [Tarantool-patches] [PATCH v4 5/5] sql: support column addition Nikita Pettik
2020-11-10 12:18     ` Roman Khabibov
2020-11-18 16:15       ` Nikita Pettik
2020-11-15 11:51         ` roman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201009134529.13212-1-roman.habibov@tarantool.org \
    --to=roman.habibov@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v4 0/5] Support column addition' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox