From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 226B0469719 for ; Fri, 9 Oct 2020 16:45:30 +0300 (MSK) From: Roman Khabibov Date: Fri, 9 Oct 2020 16:45:24 +0300 Message-Id: <20201009134529.13212-1-roman.habibov@tarantool.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v4 0/5] Support column addition List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org I alreday have LGTM from Vlad. About non empty spaces: https://github.com/tarantool/tarantool/issues/5405 Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3075-add-column-v2 Issues: https://github.com/tarantool/tarantool/issues/2349 and https://github.com/tarantool/tarantool/issues/3075 @ChangeLog * Support statement (gh-3075). Roman Khabibov (5): sql: rename TK_COLUMN to TK_COLUMN_REF sql: refactor create_table_def and parse schema: add box_space_field_MAX sql: use parser's region of "index" array sql: support column addition extra/addopcodes.sh | 2 +- extra/mkkeywordhash.c | 7 +- src/box/errcode.h | 2 + src/box/schema_def.h | 1 + src/box/sql/build.c | 617 +++++++++++++++++++++++---------- src/box/sql/expr.c | 48 +-- src/box/sql/fk_constraint.c | 2 +- src/box/sql/parse.y | 48 ++- src/box/sql/parse_def.h | 83 +++-- src/box/sql/prepare.c | 3 +- src/box/sql/resolve.c | 10 +- src/box/sql/select.c | 10 +- src/box/sql/sqlInt.h | 59 +++- src/box/sql/tokenize.c | 17 +- src/box/sql/treeview.c | 2 +- src/box/sql/where.c | 18 +- src/box/sql/whereexpr.c | 12 +- test/box/error.result | 1 + test/sql/add-column.result | 529 ++++++++++++++++++++++++++++ test/sql/add-column.test.sql | 183 ++++++++++ test/sql/checks.result | 20 ++ test/sql/checks.test.lua | 9 + test/sql/foreign-keys.result | 28 ++ test/sql/foreign-keys.test.lua | 11 + 24 files changed, 1426 insertions(+), 296 deletions(-) create mode 100644 test/sql/add-column.result create mode 100644 test/sql/add-column.test.sql -- 2.24.3 (Apple Git-128)