From: Kirill Yukhin <kyukhin@tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] lua: prohibit fiber yield when GC hook is active
Date: Tue, 6 Oct 2020 13:56:17 +0300 [thread overview]
Message-ID: <20201006105617.6lya6ikzuqsjua27@tarantool.org> (raw)
In-Reply-To: <61072ba98da2e4098b0c35cad83ffcdcbc537c8e.1601644669.git.imun@tarantool.org>
Hello,
On 02 окт 17:39, Igor Munkin wrote:
> While running GC hook (i.e. __gc metamethod) garbage collector engine
> is "stopped": the memory penalty threshold is set to LJ_MAX_MEM and
> incremental GC step is not triggered as a result. Ergo, yielding the
> execution at the finalizer body leads to further running platform with
> disabled LuaJIT GC. It is not re-enabled until the yielded fiber doesn't
> get the execution back.
>
> This changeset extends <cord_on_yield> routine with the check whether GC
> hook is active. If the switch-over occurs in scope of __gc metamethod
> the platform is forced to stop its execution with EXIT_FAILURE and calls
> panic routine before the exit.
>
> Relates to #4518
> Follows up #4727
>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
I've checked your patch into 1.10, 2.4, 2.5 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-10-06 10:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 14:39 Igor Munkin
2020-10-02 14:49 ` Igor Munkin
2020-10-04 14:02 ` Vladislav Shpilevoy
2020-10-04 18:51 ` Igor Munkin
2020-10-05 18:37 ` Sergey Ostanevich
2020-10-05 18:39 ` Igor Munkin
2020-10-05 18:43 ` Igor Munkin
2020-10-06 10:56 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006105617.6lya6ikzuqsjua27@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] lua: prohibit fiber yield when GC hook is active' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox