* [Tarantool-patches] [PATCH] box/raft: fix compilation issue
@ 2020-09-30 13:32 Cyrill Gorcunov
2020-09-30 14:41 ` Kirill Yukhin
2020-10-01 22:14 ` Vladislav Shpilevoy
0 siblings, 2 replies; 4+ messages in thread
From: Cyrill Gorcunov @ 2020-09-30 13:32 UTC (permalink / raw)
To: tml; +Cc: Vladislav Shpilevoy
Without explicit cast we're getting warnings.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
src/box/raft.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/box/raft.c b/src/box/raft.c
index e88e5adb6..0b6c373e8 100644
--- a/src/box/raft.c
+++ b/src/box/raft.c
@@ -271,7 +271,8 @@ raft_request_to_string(const struct raft_request *req)
int size = 1024;
char buf[1024];
char *pos = buf;
- int rc = snprintf(pos, size, "{term: %llu", req->term);
+ int rc = snprintf(pos, size, "{term: %llu",
+ (unsigned long long)req->term);
assert(rc >= 0);
pos += rc;
size -= rc;
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Tarantool-patches] [PATCH] box/raft: fix compilation issue
2020-09-30 13:32 [Tarantool-patches] [PATCH] box/raft: fix compilation issue Cyrill Gorcunov
@ 2020-09-30 14:41 ` Kirill Yukhin
2020-10-01 22:14 ` Vladislav Shpilevoy
1 sibling, 0 replies; 4+ messages in thread
From: Kirill Yukhin @ 2020-09-30 14:41 UTC (permalink / raw)
To: Cyrill Gorcunov; +Cc: tml, Vladislav Shpilevoy
Hello,
On 30 сен 16:32, Cyrill Gorcunov wrote:
> Without explicit cast we're getting warnings.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
I've checked your patch into master.
--
Regards, Kirill Yukhin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH] box/raft: fix compilation issue
2020-09-30 13:32 [Tarantool-patches] [PATCH] box/raft: fix compilation issue Cyrill Gorcunov
2020-09-30 14:41 ` Kirill Yukhin
@ 2020-10-01 22:14 ` Vladislav Shpilevoy
2020-10-01 22:36 ` Cyrill Gorcunov
1 sibling, 1 reply; 4+ messages in thread
From: Vladislav Shpilevoy @ 2020-10-01 22:14 UTC (permalink / raw)
To: Cyrill Gorcunov, tml
Hi! Thanks for the patch!
Unfortunately, the patch is already pushed, but for the
future - we don't have box/raft subsystem. We have just raft.
In the near future raft and box/raft will be two different
things, so better stick to the right naming.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH] box/raft: fix compilation issue
2020-10-01 22:14 ` Vladislav Shpilevoy
@ 2020-10-01 22:36 ` Cyrill Gorcunov
0 siblings, 0 replies; 4+ messages in thread
From: Cyrill Gorcunov @ 2020-10-01 22:36 UTC (permalink / raw)
To: Vladislav Shpilevoy; +Cc: tml
On Fri, Oct 02, 2020 at 12:14:17AM +0200, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
> Unfortunately, the patch is already pushed, but for the
> future - we don't have box/raft subsystem. We have just raft.
> In the near future raft and box/raft will be two different
> things, so better stick to the right naming.
Sure! Sorry, didn't know in first place.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-01 22:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30 13:32 [Tarantool-patches] [PATCH] box/raft: fix compilation issue Cyrill Gorcunov
2020-09-30 14:41 ` Kirill Yukhin
2020-10-01 22:14 ` Vladislav Shpilevoy
2020-10-01 22:36 ` Cyrill Gorcunov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox