From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2.X 5/7] module api: luaT_temp_luastate & luaT_release_temp_luastate
Date: Thu, 1 Oct 2020 06:35:20 +0300 [thread overview]
Message-ID: <20201001033520.w3jebtdr57hfrtcb@tkn_work_nb> (raw)
In-Reply-To: <0dbdbece-3f14-ba6d-b7ca-50f39f3b46d6@tarantool.org>
On Wed, Sep 30, 2020 at 01:21:13AM +0200, Vladislav Shpilevoy wrote:
> On 29.09.2020 07:17, Alexander Turenko wrote:
> > On Tue, Sep 29, 2020 at 12:21:18AM +0200, Vladislav Shpilevoy wrote:
> >> Thanks for the patch!
> >>
> >> I strongly don't like this export. It seems to be too internal.
> >
> > I have no point to start discussion. Can you clarify your feeling?
>
> I don't like that we give access to fiber's Lua state. If a user will
> leave anything on it, it can lead to anything as well, UB I guess. But
> I didn't check.
>
> >> But I have no better ideas than propose to implement your own
> >> lua_State cache in the merger module. It does not seem to be too
> >> hard, and I don't think it would occupy much memory.
> >>
> >> Just a simple list of lua_State objects, created by luaT_newthread
> >> on demand, and put back into the list when unused. What is wrong
> >> with that?
> >
> > When we able to simplify modules, it worth to do so (when there are no
> > certain objections). Write once, use many.
>
> What are applications for that except the merger? Potentially.
When we want to call a Lua function (some callback), which can
potentially yield (so we can't use luaT_state()), but we have no direct
access to some current Lua state. It may be because we're in box C
function or because of API design: for merger it is because API of
source's virtual functions are Lua agnostic.
So... maybe other projects with pure C part and Lua/C part, where C code
may call Lua/C code in some way. Say, when there is general pure C code and
particular implementation of some API, which works with Lua objects.
Something designed as quite extensible thing.
Anyway, I already agreed that it is not as simple as cache and we should
return back to it later if there will be a need.
next prev parent reply other threads:[~2020-10-01 3:35 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 17:00 [Tarantool-patches] [PATCH 2.X 0/7] RFC: module api: extend for external merger Lua module Timur Safin
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 1/7] module api: export box_tuple_validate Timur Safin
2020-09-28 22:20 ` Vladislav Shpilevoy
2020-10-02 12:24 ` Timur Safin
2020-10-09 1:11 ` Alexander Turenko
2020-10-09 20:11 ` Vladislav Shpilevoy
2020-10-10 1:19 ` Alexander Turenko
2020-09-29 5:25 ` Alexander Turenko
2020-10-05 7:35 ` Alexander Turenko
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 2/7] module api: export box_key_def_dup Timur Safin
2020-09-28 22:21 ` Vladislav Shpilevoy
2020-09-29 5:03 ` Alexander Turenko
2020-09-29 23:19 ` Vladislav Shpilevoy
2020-10-01 3:05 ` Alexander Turenko
2020-10-02 12:25 ` Timur Safin
2020-10-02 12:26 ` Timur Safin
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 3/7] module api: luaT_newthread Timur Safin
2020-09-28 22:21 ` Vladislav Shpilevoy
2020-10-02 12:27 ` Timur Safin
2020-10-02 21:48 ` Vladislav Shpilevoy
2020-09-29 6:25 ` Alexander Turenko
2020-10-02 12:26 ` Timur Safin
2020-10-02 12:53 ` Alexander Turenko
2020-09-29 15:19 ` Igor Munkin
2020-10-02 16:12 ` Timur Safin
2020-10-03 16:57 ` Igor Munkin
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 4/7] module api: luaL_register_module & luaL_register_type Timur Safin
2020-09-28 22:21 ` Vladislav Shpilevoy
2020-09-29 5:09 ` Alexander Turenko
2020-09-29 23:20 ` Vladislav Shpilevoy
2020-09-30 6:31 ` Alexander Turenko
2020-09-30 6:33 ` Alexander Turenko
2020-10-02 16:14 ` Timur Safin
2020-09-29 8:03 ` Igor Munkin
2020-09-29 23:21 ` Vladislav Shpilevoy
2020-10-02 16:14 ` Timur Safin
2020-10-03 3:24 ` Alexander Turenko
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 5/7] module api: luaT_temp_luastate & luaT_release_temp_luastate Timur Safin
2020-09-28 22:21 ` Vladislav Shpilevoy
2020-09-29 5:17 ` Alexander Turenko
2020-09-29 23:21 ` Vladislav Shpilevoy
2020-10-01 3:35 ` Alexander Turenko [this message]
2020-09-29 15:10 ` Igor Munkin
2020-09-29 21:03 ` Alexander Turenko
2020-09-29 23:23 ` Vladislav Shpilevoy
2020-09-30 10:09 ` Alexander Turenko
2020-10-01 15:06 ` Igor Munkin
2020-10-03 2:16 ` Alexander Turenko
2020-10-02 12:24 ` Timur Safin
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 6/7] module api: luaL_checkibuf & luaL_checkconstchar Timur Safin
2020-09-28 22:21 ` Vladislav Shpilevoy
2020-09-29 5:53 ` Alexander Turenko
2020-09-29 23:25 ` Vladislav Shpilevoy
2020-10-01 3:00 ` Alexander Turenko
2020-10-02 16:14 ` Timur Safin
2020-10-02 21:48 ` Vladislav Shpilevoy
2020-10-08 13:50 ` Timur Safin
2020-09-24 17:00 ` [Tarantool-patches] [PATCH 2.X 7/7] module api: luaL_cdata_iscallable Timur Safin
2020-09-28 22:21 ` Vladislav Shpilevoy
2020-09-29 5:19 ` Alexander Turenko
2020-10-02 16:14 ` Timur Safin
2020-10-02 12:23 ` [Tarantool-patches] [PATCH 2.X 0/7] RFC: module api: extend for external merger Lua module Timur Safin
2020-10-02 21:49 ` Vladislav Shpilevoy
2020-10-03 2:54 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001033520.w3jebtdr57hfrtcb@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2.X 5/7] module api: luaT_temp_luastate & luaT_release_temp_luastate' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox