From: Igor Munkin <imun@tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 2/2] lua: abort trace recording on fiber yield
Date: Tue, 29 Sep 2020 13:06:15 +0300 [thread overview]
Message-ID: <20200929100615.GX18920@tarantool.org> (raw)
In-Reply-To: <20200929092412.GC35@tarantool.org>
Sergos,
Thanks for your review!
On 29.09.20, Sergey Ostanevich wrote:
> Hi!
>
> Thanks for the patch!
>
> I wonder how many tests are failing due to #4819 and are they covered
> with skip conditions?
I know only three: this one and two from LuaJIT tests (for FFI sandwich
and flushing trace while running one).
> Also, how will we fix all those tests after FreeBSD fixup?
Just remove this skipcond file. The problem is JIT fails to assemble the
recorded trace, so the mcode is not generated and the "desired" platform
panic doesn't occur. When the issue is fixed, the test should be fine.
>
> The patchset is LGTM to me.
Added your tag:
| Reviewed-by: Sergey Ostanevich <sergos@tarantool.org>
>
> Regards,
> Sergos
>
> On 28 сен 20:45, Igor Munkin wrote:
> > Meh, the last one (I hope): I forgot there are the issues with JIT on
> > FreeBSD[1]. So I added skipcond file for the newly added test:
> >
<snipped>
> >
> > [1]: https://github.com/tarantool/tarantool/issues/4819
> >
> > --
> > Best regards,
> > IM
--
Best regards,
IM
next prev parent reply other threads:[~2020-09-29 10:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 19:06 [Tarantool-patches] [PATCH v2 0/2] Prevent JIT engine breakage on fibers switch-over Igor Munkin
2020-09-23 19:06 ` [Tarantool-patches] [PATCH v2 1/2] fiber: introduce a callback for " Igor Munkin
2020-09-24 12:54 ` sergos
2020-09-28 13:06 ` Igor Munkin
2020-09-29 9:15 ` Sergey Ostanevich
2020-09-29 10:05 ` Igor Munkin
2020-09-29 22:41 ` Vladislav Shpilevoy
2020-09-30 9:30 ` Igor Munkin
2020-09-30 22:00 ` Vladislav Shpilevoy
2020-09-23 19:06 ` [Tarantool-patches] [PATCH v2 2/2] lua: abort trace recording on fiber yield Igor Munkin
2020-09-24 13:00 ` sergos
2020-09-28 13:07 ` Igor Munkin
2020-09-28 15:36 ` Igor Munkin
2020-09-28 16:37 ` Igor Munkin
2020-09-28 17:45 ` Igor Munkin
2020-09-29 9:24 ` Sergey Ostanevich
2020-09-29 10:06 ` Igor Munkin [this message]
2020-09-29 22:41 ` Vladislav Shpilevoy
2020-09-30 6:27 ` Igor Munkin
2020-09-30 21:59 ` Vladislav Shpilevoy
2020-10-01 6:14 ` Igor Munkin
2020-09-24 13:15 ` [Tarantool-patches] [PATCH v2 0/2] Prevent JIT engine breakage on fibers switch-over sergos
2020-09-28 13:06 ` Igor Munkin
2020-09-29 9:14 ` Sergey Ostanevich
2020-10-01 21:25 ` Vladislav Shpilevoy
2020-10-01 21:29 ` Igor Munkin
2020-10-01 22:17 ` Igor Munkin
2020-10-02 12:43 ` Kirill Yukhin
2020-10-02 12:44 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929100615.GX18920@tarantool.org \
--to=imun@tarantool.org \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 2/2] lua: abort trace recording on fiber yield' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox