Tarantool development patches archive
 help / color / mirror / Atom feed
From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Timur Safin <tsafin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1.10 7/9] RFC: module api: extend list of public symbols in 1.10
Date: Tue, 29 Sep 2020 09:21:13 +0300	[thread overview]
Message-ID: <20200929062113.xquertrd5dbjxkxe@tkn_work_nb> (raw)
In-Reply-To: <b48c0449b43da8ed775b6e498c3323dea24c4807.1600955796.git.tsafin@tarantool.org>

> diff --git a/extra/exports b/extra/exports
> index a4ac03530..70b59a0a6 100644
> --- a/extra/exports
> +++ b/extra/exports
> @@ -118,7 +118,10 @@ coio_call
>  coio_getaddrinfo
>  luaL_pushcdata
>  luaL_iscdata
> +luaL_iscallable

It should be part of relevant commits (just like on your 2.x branch).
The same for the other functions.

Or you may have one commit for backport (just cherry-pick) and a
separate commit with \public cond + exports.

> +mp_char2escape
> +mp_decode_extl
> +mp_ext_hint
> +mp_format
> +mp_fprint
> +mp_parser_hint
> +mp_snprint
> +mp_type_hint
> +mp_vformat

Those functions are not used in merger. It seems you want to overcome
some linking problem. At least, please, explain this change.

Anyway, including msgpuck headers and using symbols from tarantool looks
dangerous. Maybe we can just expose necessary mp_*() functions into box
api: both to headers and to public symbols, as we usually do?

I looked, the list is not large: mp_next(), mp_check(), mp_store_u32(),
mp_typeof(), mp_check_array(), mp_decode_array(), mp_sizeof_array(),
mp_encode_array() and MP_ARRAY constant.

Alternative: bundle msgpuck into the module, but tweak it to be header
only back (add some ifdefs). This way, I guess, it would be safe to use
external msgpuck and don't bother about symbol names clash (need to
verify, though). At least if mp_next() / mp_check() successfully
traverse over unknown mp_ext (I guess it is so) and you don't need to
parse specific mp_ext types. It'll be enough for most use cases I guess.

  reply	other threads:[~2020-09-29  6:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 21:00 [Tarantool-patches] [PATCH 1.10 0/9] RFC: module api: extend for external merger Lua module Timur Safin
2020-09-24 21:00 ` [Tarantool-patches] [PATCH 1.10 1/9] module api: export box_tuple_validate Timur Safin
2020-09-24 21:00 ` [Tarantool-patches] [PATCH 1.10 2/9] module api: export box_key_def_dup Timur Safin
2020-09-24 21:00 ` [Tarantool-patches] [PATCH 1.10 3/9] module api: luaT_newthread Timur Safin
2020-09-24 21:00 ` [Tarantool-patches] [PATCH 1.10 4/9] module api: luaL_register_module & luaL_register_type Timur Safin
2020-09-24 21:00 ` [Tarantool-patches] [PATCH 1.10 5/9] module api: luaT_temp_luastate & luaT_release_temp_luastate Timur Safin
2020-09-24 21:00 ` [Tarantool-patches] [PATCH 1.10 6/9] module api: luaL_checkibuf & luaL_checkconstchar Timur Safin
2020-09-24 21:00 ` [Tarantool-patches] [PATCH 1.10 7/9] RFC: module api: extend list of public symbols in 1.10 Timur Safin
2020-09-29  6:21   ` Alexander Turenko [this message]
2020-09-24 21:00 ` [Tarantool-patches] [PATCH 1.10 8/9] module api: add luaL_iscallable with support of cdata metatype Timur Safin
2020-09-24 21:00 ` [Tarantool-patches] [PATCH 1.10 9/9] module api: luaL_cdata_iscallable Timur Safin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200929062113.xquertrd5dbjxkxe@tkn_work_nb \
    --to=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=tsafin@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1.10 7/9] RFC: module api: extend list of public symbols in 1.10' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox