From: Mergen Imeev <imeevma@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v5 1/6] sql: remove unused DOUBLE to INTEGER conversion
Date: Mon, 28 Sep 2020 18:50:37 +0300 [thread overview]
Message-ID: <20200928155037.GA77246@tarantool.org> (raw)
In-Reply-To: <20200917144808.GG10599@tarantool.org>
Hi! Thank you for the review. My answer below.
On Thu, Sep 17, 2020 at 02:48:08PM +0000, Nikita Pettik wrote:
> On 21 Aug 12:19, imeevma@tarantool.org wrote:
> > This patch removes the unused DOUBLE to INTEGER conversion from OP_Seek*
> > opcodes. This transformation is not used due to changes in the ApplyType
>
> What changes are..?
Changed commit-message a bit:
This patch removes the unused DOUBLE to INTEGER conversion from OP_Seek*
opcodes. This conversion is not used due to changes in the ApplyType
opcode after #3809. The next few patches will introduce new rules for
converting numbers (not just DOUBLE to INTEGER), and the implicit
conversion within the ApplyType opcode will be disabled for this case.
>
> > opcode. The next few patches will introduce new rules for converting
> > numbers (not just DOUBLE to INTEGER), and the implicit conversion within
> > the ApplyType opcode will be disabled for this case.
> >
> > Part of #4230
>
> LGTM
next prev parent reply other threads:[~2020-09-28 15:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 9:19 [Tarantool-patches] [PATCH v5 0/6] sql; remove implicit cast for comparison imeevma
2020-08-21 9:19 ` [Tarantool-patches] [PATCH v5 1/6] sql: remove unused DOUBLE to INTEGER conversion imeevma
2020-09-17 14:48 ` Nikita Pettik
2020-09-28 15:50 ` Mergen Imeev [this message]
2020-08-21 9:19 ` [Tarantool-patches] [PATCH v5 2/6] sql: add implicit cast between numbers in OP_Seek* imeevma
2020-09-17 15:34 ` Nikita Pettik
2020-09-28 15:55 ` Mergen Imeev
2020-08-21 9:19 ` [Tarantool-patches] [PATCH v5 3/6] sql: change comparison between numbers using index imeevma
2020-09-18 8:08 ` Nikita Pettik
2020-09-28 16:10 ` Mergen Imeev
2020-08-21 9:19 ` [Tarantool-patches] [PATCH v5 4/6] sql: remove implicit cast from comparison opcodes imeevma
2020-08-21 9:19 ` [Tarantool-patches] [PATCH v5 5/6] sql: fix implicit cast in opcode MustBeInt imeevma
2020-08-21 9:19 ` [Tarantool-patches] [PATCH v5 6/6] sql: remove implicit cast from MakeRecord opcode imeevma
2020-09-18 12:28 ` Nikita Pettik
2020-09-28 16:19 ` Mergen Imeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928155037.GA77246@tarantool.org \
--to=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v5 1/6] sql: remove unused DOUBLE to INTEGER conversion' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox