Re: [Tarantool-patches] [avtikhon@tarantool.org: [PATCH v1] test: flaky replication/anon.test.lua test]

Re: [Tarantool-patches] [avtikhon@tarantool.org: [PATCH v1] test: flaky replication/anon.test.lua test]

[Serge Petrenko]

11.09.2020 09:24, Alexander V. Tikhonov пишет:
> Hi Sergey, could you please review the following patch, thank you.

Hi, Alexander!  Thanks for the patch.


I don't like the idea of restarting the default instance every now and 
then, but ok.

>
> ----- Forwarded message from "Alexander V. Tikhonov" <avtikhon@tarantool.org> -----
>
> Date: Wed, 19 Aug 2020 11:17:49 +0300
> From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
> To: Kirill Yukhin <kyukhin@tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org>
> Cc: "Alexander V. Tikhonov" <avtikhon@tarantool.org>, tarantool-patches@dev.tarantool.org
> Subject: [PATCH v1] test: flaky replication/anon.test.lua test
> X-Mailer: git-send-email 2.17.1
>
> Found flaky issues multi running replication/anon.test.lua test
> on the single worker:
>
>   [007] --- replication/anon.result	Fri Jun  5 09:02:25 2020
>   [007] +++ replication/anon.reject	Mon Jun  8 01:19:37 2020
>   [007] @@ -55,7 +55,7 @@
>   [007]
>   [007]  box.info.status
>   [007]   | ---
>   [007] - | - running
>   [007] + | - orphan
>   [007]   | ...
>   [007]  box.info.id
>   [007]   | ---
>
>   [094] --- replication/anon.result       Sat Jun 20 06:02:43 2020
>   [094] +++ replication/anon.reject       Tue Jun 23 19:35:28 2020
>   [094] @@ -154,7 +154,7 @@
>   [094]  -- Test box.info.replication_anon.
>   [094]  box.info.replication_anon
>   [094]   | ---
>   [094] - | - count: 1
>   [094] + | - count: 2
>   [094]   | ...
>   [094]  #box.info.replication_anon()
>   [094]   | ---
>   [094]
>
> It happend because replications may stay active from the previous
> runs on the common tarantool instance at the test-run worker. To
> avoid of it added restarting of the tarantool instance at the very
> start of the test.
>
> Closes #5058
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5058-repl-anon
> Issue: https://github.com/tarantool/tarantool/issues/5058
>
>   test/replication/anon.result   | 2 ++
>   test/replication/anon.test.lua | 1 +
>   test/replication/suite.ini     | 1 -
>   3 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/test/replication/anon.result b/test/replication/anon.result
> index 2b880b94b..dd470797c 100644
> --- a/test/replication/anon.result
> +++ b/test/replication/anon.result
> @@ -8,6 +8,8 @@ vclock_diff = require('fast_replica').vclock_diff
>   test_run = env.new()
>    | ---
>    | ...
> +test_run:cmd('restart server default')
> + |
>   
>   
>   --
> diff --git a/test/replication/anon.test.lua b/test/replication/anon.test.lua
> index b42602d50..2cc77595b 100644
> --- a/test/replication/anon.test.lua
> +++ b/test/replication/anon.test.lua
> @@ -1,6 +1,7 @@
>   env = require('test_run')
>   vclock_diff = require('fast_replica').vclock_diff
>   test_run = env.new()
> +test_run:cmd('restart server default')
>   
>   
>   --
> diff --git a/test/replication/suite.ini b/test/replication/suite.ini
> index ab9c3dabd..49d81e54d 100644
> --- a/test/replication/suite.ini
> +++ b/test/replication/suite.ini
> @@ -22,5 +22,4 @@ fragile = errinj.test.lua            ; gh-3870
>             recover_missing_xlog.test.lua ; gh-4989
>             box_set_replication_stress.test.lua     ; gh-4992 gh-4986
>             gh-4605-empty-password.test.lua         ; gh-5030
> -          anon.test.lua              ; gh-5058
>             status.test.lua            ; gh-5110

-- 
Serge Petrenko

Re: [Tarantool-patches] [avtikhon@tarantool.org: [PATCH v1] test: flaky replication/anon.test.lua test]

[Kirill Yukhin]

Hello,

On 14 сен 10:29, Serge Petrenko wrote:
> 
> 11.09.2020 09:24, Alexander V. Tikhonov пишет:
> > Hi Sergey, could you please review the following patch, thank you.
> 
> Hi, Alexander!  Thanks for the patch.
> 
> 
> I don't like the idea of restarting the default instance every now and then,
> but ok.


I've checked your patch into 2.4, 2.5 and master.

--
Regards, Kirill Yukhin