From: Sergey Kaplun <skaplun@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] cppcheck: src/lua/fiber.c null pointer dereference
Date: Thu, 24 Sep 2020 14:31:35 +0300 [thread overview]
Message-ID: <20200924113135.GB7363@root> (raw)
In-Reply-To: <20200924093254.dhm4hzlerfwftfkn@tkn_work_nb>
On 24.09.20, Alexander Turenko wrote:
> On Thu, Sep 24, 2020 at 02:16:20AM +0300, Alexander Turenko wrote:
<snipped>
>
> Moved to https://github.com/tarantool/tarantool/issues/5326
I've added comment about this behaviour:
```
diff --git a/src/lua/fiber.c b/src/lua/fiber.c
index 1c7d9cdb6..efb0a4921 100644
--- a/src/lua/fiber.c
+++ b/src/lua/fiber.c
@@ -214,6 +214,11 @@ fiber_backtrace_cb(int frameno, void *frameret, const char *func, size_t offset,
{
struct lua_fiber_tb_ctx *tb_ctx = (struct lua_fiber_tb_ctx *)cb_ctx;
struct lua_State *L = tb_ctx->L;
+ /*
+ * There is impossible to get func == NULL until
+ * https://github.com/tarantool/tarantool/issues/5326
+ * will not resolved, but is possible afterwards.
+ */
if (func != NULL && strstr(func, "lj_BC_FUNCC") == func) {
/* We are in the LUA vm. */
lua_Debug ar;
```
You can see other fixes in [1]
[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-September/019636.html
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2020-09-24 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 17:48 Sergey Kaplun
2020-09-22 5:07 ` Sergey Kaplun
2020-09-23 23:16 ` Alexander Turenko
2020-09-24 9:22 ` Sergey Kaplun
2020-09-24 9:32 ` Alexander Turenko
2020-09-24 11:31 ` Sergey Kaplun [this message]
2020-09-28 6:54 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924113135.GB7363@root \
--to=skaplun@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] cppcheck: src/lua/fiber.c null pointer dereference' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox