From: Sergey Kaplun <skaplun@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>,
Leonid Vasiliev <lvasiliev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH] cppcheck: src/lua/fiber.c null pointer dereference
Date: Mon, 21 Sep 2020 20:48:37 +0300 [thread overview]
Message-ID: <20200921174837.30681-1-skaplun@tarantool.org> (raw)
Found and fixed possible null pointer dereference with cppcheck:
[src/lua/fiber.c:245] -> [src/lua/fiber.c:217]: (warning) Either the condition 'if(func)' is redundant or there is possible null pointer dereference: func.
---
Branch: https://github.com/tarantool/tarantool/tree/skaplun/cppcheck-lua-fiber-possible-null-pointer-dereference
src/lua/fiber.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lua/fiber.c b/src/lua/fiber.c
index 45bc03787..bb6212b24 100644
--- a/src/lua/fiber.c
+++ b/src/lua/fiber.c
@@ -214,7 +214,7 @@ fiber_backtrace_cb(int frameno, void *frameret, const char *func, size_t offset,
{
struct lua_fiber_tb_ctx *tb_ctx = (struct lua_fiber_tb_ctx *)cb_ctx;
struct lua_State *L = tb_ctx->L;
- if (strstr(func, "lj_BC_FUNCC") == func) {
+ if (func && strstr(func, "lj_BC_FUNCC") == func) {
/* We are in the LUA vm. */
lua_Debug ar;
while (tb_ctx->R && lua_getstack(tb_ctx->R, tb_ctx->lua_frame, &ar) > 0) {
--
2.28.0
next reply other threads:[~2020-09-21 17:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 17:48 Sergey Kaplun [this message]
2020-09-22 5:07 ` Sergey Kaplun
2020-09-23 23:16 ` Alexander Turenko
2020-09-24 9:22 ` Sergey Kaplun
2020-09-24 9:32 ` Alexander Turenko
2020-09-24 11:31 ` Sergey Kaplun
2020-09-28 6:54 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921174837.30681-1-skaplun@tarantool.org \
--to=skaplun@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] cppcheck: src/lua/fiber.c null pointer dereference' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox