Re: [Tarantool-patches] [PATCH v3] gitlab-ci: save failed test results artifacts

[Alexander Turenko <alexander.turenko@tarantool.org>]

Nothing contradicts with my vision (I became a bit more far from details
now). LGTM. Several comments below (no need to re-review with me if
you'll want to make changes according to those comments).

WBR, Alexander Turenko.

>  .vbox_template: &vbox_definition
>    stage: test
>    after_script:
> -    - ${GITLAB_MAKE} vms_shutdown
> +    - >
> +      scp -r -P ${VMS_PORT} ${VMS_USER}@127.0.0.1:tarantool/test/var/artifacts . ;
> +      ${GITLAB_MAKE} vms_shutdown
> +  <<: *artifacts_files_definition

Nit: Using literal style indicator (the pipe symbol instead of the angle
bracket) would look more intuitive and does not require the semicolon.
(The folded style ('>') replaces newlines with spaces and it should be
used when this behaviour is wanted I think.)

>  static_build_cmake_osx_15:
> -  stage: test
> +  <<: *osx_definition
>    tags:
>      - osx_15
>    script:

Nit: This change is not mentioned in the commit message.

> diff --git a/.travis.mk b/.travis.mk
> index d8f97ef5c..577970d8f 100644
> --- a/.travis.mk
> +++ b/.travis.mk
> @@ -242,11 +242,11 @@ INIT_TEST_ENV_OSX=\
>  		launchctl limit maxproc || : ; \
>  		ulimit -u ${MAX_PROC} || : ; \
>  		ulimit -u ; \
> -		rm -rf /tmp/tnt
> +		rm -rf ${OSX_VARDIR}

Just in case: should not we set some default value for this variable in
case we'll run this rule outside of CI (or in CI, which is not GitLab
CI)?