From: "Alexander V. Tikhonov" <avtikhon@tarantool.org> To: Kirill Yukhin <kyukhin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH] coio: fix cord leak on stop Date: Wed, 23 Sep 2020 08:18:03 +0300 [thread overview] Message-ID: <20200923051802.GA10528@hpalx> (raw) In-Reply-To: <ecb3c3dba9338ecee6387cc4b74671a938d48389.1600786660.git.kyukhin@tarantool.org> Hi Kirill, thanks for the patch. I've checked it and seems that the fixed lsan susspension can be removed, please use the following patch before commit to releases: diff --git a/asan/lsan.supp b/asan/lsan.supp index 46b3001e9..f1ec60da3 100644 --- a/asan/lsan.supp +++ b/asan/lsan.supp @@ -43,8 +43,6 @@ leak:tt_bitset_iterator_init leak:libc.so* # test: box-tap/schema_mt.test.lua -# source: src/lib/core/coio_task.c -leak:coio_on_start # source: src/lib/salad/mhash.h leak:mh_i32ptr_new Also the patch LGTM. On Tue, Sep 22, 2020 at 05:59:47PM +0300, Kirill Yukhin wrote: > cord_ptr variable is calloc()-ated in coio_on_start() > and is not free()-ed, which triggers ASAN. free() it > in coio_on_stop(). > > Closes #5308 > --- > > Branch: https://github.com/tarantool/tarantool/tree/kyukhin/gh-5308-cord-leak > Issue: https://github.com/tarantool/tarantool/issues/5308 > ChangeLog: not user visible > > src/lib/core/coio_task.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/lib/core/coio_task.c b/src/lib/core/coio_task.c > index 83f669d..c8be2de 100644 > --- a/src/lib/core/coio_task.c > +++ b/src/lib/core/coio_task.c > @@ -123,6 +123,7 @@ coio_on_stop(void *data) > { > (void) data; > cord_destroy(cord()); > + free(cord()); > return 0; > } > > -- > 1.8.3.1 >
next prev parent reply other threads:[~2020-09-23 5:18 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-22 14:59 Kirill Yukhin 2020-09-22 15:10 ` Cyrill Gorcunov 2020-09-23 5:18 ` Alexander V. Tikhonov [this message] 2020-09-23 10:58 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200923051802.GA10528@hpalx \ --to=avtikhon@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] coio: fix cord leak on stop' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox