Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun <skaplun@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] cppcheck: box/alter.cc null pointer dereference
Date: Mon, 21 Sep 2020 23:37:06 +0300	[thread overview]
Message-ID: <20200921203706.GA20060@root> (raw)
In-Reply-To: <539965bb-7c2b-6962-530f-d9494a71b260@tarantool.org>

Hi! Thanks for the review!

On 21.09.20, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> 
> Commit title should be a subsystem name + description. Since we
> don't have 'cppcheck' subsystem, I propose to use 'alter'.
> 
> LGTM except the commit title.

I've updated commit message to:

```
alter: box/alter.cc null pointer dereference

Found and fixed Null pointer dereference with cppcheck:

[src/box/alter.cc:395]: (error) Null pointer dereference
```
and pushed it to the branch.

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2020-09-21 20:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-20 17:59 Sergey Kaplun
2020-09-21 20:15 ` Vladislav Shpilevoy
2020-09-21 20:37   ` Sergey Kaplun [this message]
2020-09-21 21:39     ` Vladislav Shpilevoy
2020-09-28  6:59 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200921203706.GA20060@root \
    --to=skaplun@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] cppcheck: box/alter.cc null pointer dereference' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox