From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: sergeyb@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/4] cmake: add targets to run Jepsen tests
Date: Fri, 18 Sep 2020 17:23:06 +0300 [thread overview]
Message-ID: <20200918142306.GB27064@hpalx> (raw)
In-Reply-To: <bf432ee3345e867985d35cacd31d5e48d72769d8.1600239621.git.sergeyb@tarantool.org>
Hi Sergey, thanks for the patch. It has 2 make targets which will be
usable for tests reproduce. Later I hope we'll make some more
instructions on its use, but not now, so patch LGTM.
On Wed, Sep 16, 2020 at 10:07:21AM +0300, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
>
> Added targets 'make jepsen-single' and 'make jepsen-cluster'
> to run Jepsen tests on a single Tarantool instance and
> cluster of Tarantool instances.
>
> Part of #5277
> ---
> CMakeLists.txt | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 695e80c21..e8850e320 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -17,9 +17,11 @@ include(TestBigEndian)
> include(CheckFunctionExists)
> include(FindOptionalPackage)
> include(FindPackageMessage)
> +include(ExternalProject)
>
> find_program(ECHO echo)
> find_program(CAT cat)
> +find_program(BASH bash)
> find_program(GIT git)
> find_program(LD ld)
> find_program(CTAGS ctags)
> @@ -162,6 +164,31 @@ add_custom_command(TARGET luacheck
> COMMENT "Perform static analysis of Lua code"
> )
>
> +ExternalProject_Add(
> + jepsen-tests
> + GIT_REPOSITORY https://github.com/tarantool/jepsen.tarantool
> + CONFIGURE_COMMAND ""
> + BUILD_COMMAND ""
> + INSTALL_COMMAND ""
> + TEST_COMMAND ""
> +)
> +
> +#
> +# Enable 'make jepsen-*' targets.
> +#
> +
> +add_custom_target(jepsen-single DEPENDS jepsen-tests)
> +add_custom_command(TARGET jepsen-single
> + COMMAND ${BASH} ${PROJECT_SOURCE_DIR}/tools/run-jepsen-tests.sh ${PROJECT_SOURCE_DIR} ${PROJECT_BINARY_DIR}
> + COMMENT "Running Jepsen tests on a single Tarantool instance"
> +)
> +
> +add_custom_target(jepsen-cluster DEPENDS jepsen-tests)
> +add_custom_command(TARGET jepsen-cluster
> + COMMAND ${BASH} ${PROJECT_SOURCE_DIR}/tools/run-jepsen-tests.sh ${PROJECT_SOURCE_DIR} ${PROJECT_BINARY_DIR} 5
> + COMMENT "Running Jepsen tests on a cluster with 5 Tarantool instances"
> +)
> +
> #
> # Get version
> #
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-09-18 14:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 7:07 [Tarantool-patches] [PATCH 0/4] Integrate Jepsen tests to CI sergeyb
2020-09-16 7:07 ` [Tarantool-patches] [PATCH 1/4] extra: add Terraform config files sergeyb
2020-09-18 14:20 ` Alexander V. Tikhonov
2020-09-16 7:07 ` [Tarantool-patches] [PATCH 2/4] cmake: add targets to run Jepsen tests sergeyb
2020-09-18 14:23 ` Alexander V. Tikhonov [this message]
2020-09-16 7:07 ` [Tarantool-patches] [PATCH 3/4] tools: add script " sergeyb
2020-09-18 14:32 ` Alexander V. Tikhonov
2020-09-16 7:07 ` [Tarantool-patches] [PATCH 4/4] ci: integrate Jepsen tests to GitLab CI sergeyb
2020-09-17 7:12 ` Alexander V. Tikhonov
2020-09-17 15:25 ` Alexander Turenko
2020-09-18 12:28 ` Sergey Bronnikov
2020-09-18 12:34 ` Alexander V. Tikhonov
2020-09-18 12:33 ` Sergey Bronnikov
2020-09-18 15:03 ` [Tarantool-patches] [PATCH 0/4] Integrate Jepsen tests to CI Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918142306.GB27064@hpalx \
--to=avtikhon@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/4] cmake: add targets to run Jepsen tests' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox