Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [Tarantool-patches] [PATCH 0/3] lua/pwd: workaround the systemd bug
Date: Thu, 17 Sep 2020 16:51:18 +0300	[thread overview]
Message-ID: <20200917135121.60380-1-gorcunov@gmail.com> (raw)

Guys, take a look please once time permit. The first two patches
are optional but I think while we're at this code and we could
improve the code base we should.

Also I've been thinking on how to test the issue -- we need a buggy
systemd instance running and we actually have Fedora 29 on gitlab
where tests are passed but it is unclear for me how exactly we could
use it. Initially I thought of injecting some error code into pwd module
itself but then I left this idea of making code more ugly just because
of some bug in the particular systemd version.

So my criteria was that the change must not break anything in existing
tests but if you have some idea for testing, please share.

issue https://github.com/tarantool/tarantool/issues/5034
branch gorcunov/gh-5034-passwd

Cyrill Gorcunov (3):
  lua/errno: use lengthof helper
  lua/errno: shrink memory usage on error declaration
  lua/pwd: workaround the systemd bug

 src/lua/errno.c |  5 ++---
 src/lua/pwd.lua | 52 +++++++++++++++++++++++++++++++++++++------------
 2 files changed, 42 insertions(+), 15 deletions(-)


base-commit: c1f72aeb7657a95cbce94f700ab432ba16cecb92
-- 
2.26.2

             reply	other threads:[~2020-09-17 13:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 13:51 Cyrill Gorcunov [this message]
2020-09-17 13:51 ` [Tarantool-patches] [PATCH 1/3] lua/errno: use lengthof helper Cyrill Gorcunov
2020-09-17 13:51 ` [Tarantool-patches] [PATCH 2/3] lua/errno: shrink memory usage on error declaration Cyrill Gorcunov
2020-09-17 13:51 ` [Tarantool-patches] [PATCH 3/3] lua/pwd: workaround the systemd bug Cyrill Gorcunov
2020-09-18 11:54   ` Cyrill Gorcunov
2020-09-18 12:26 ` [Tarantool-patches] [PATCH 0/3] " Kirill Yukhin
2020-09-18 12:39   ` Cyrill Gorcunov
2020-09-21  1:45 ` Alexander Turenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917135121.60380-1-gorcunov@gmail.com \
    --to=gorcunov@gmail.com \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/3] lua/pwd: workaround the systemd bug' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox