From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EF5A7469719 for ; Thu, 17 Sep 2020 16:51:26 +0300 (MSK) Received: by mail-lf1-f65.google.com with SMTP id y17so2261601lfa.8 for ; Thu, 17 Sep 2020 06:51:26 -0700 (PDT) From: Cyrill Gorcunov Date: Thu, 17 Sep 2020 16:51:18 +0300 Message-Id: <20200917135121.60380-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 0/3] lua/pwd: workaround the systemd bug List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tml Cc: Alexander Turenko Guys, take a look please once time permit. The first two patches are optional but I think while we're at this code and we could improve the code base we should. Also I've been thinking on how to test the issue -- we need a buggy systemd instance running and we actually have Fedora 29 on gitlab where tests are passed but it is unclear for me how exactly we could use it. Initially I thought of injecting some error code into pwd module itself but then I left this idea of making code more ugly just because of some bug in the particular systemd version. So my criteria was that the change must not break anything in existing tests but if you have some idea for testing, please share. issue https://github.com/tarantool/tarantool/issues/5034 branch gorcunov/gh-5034-passwd Cyrill Gorcunov (3): lua/errno: use lengthof helper lua/errno: shrink memory usage on error declaration lua/pwd: workaround the systemd bug src/lua/errno.c | 5 ++--- src/lua/pwd.lua | 52 +++++++++++++++++++++++++++++++++++++------------ 2 files changed, 42 insertions(+), 15 deletions(-) base-commit: c1f72aeb7657a95cbce94f700ab432ba16cecb92 -- 2.26.2