From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] serilaizer: check for recursive serialization
Date: Mon, 14 Sep 2020 19:06:10 +0300 [thread overview]
Message-ID: <20200914160610.GD991329@grain> (raw)
In-Reply-To: <A3C4705A-327D-42F4-857F-01383EF1E517@tarantool.org>
On Mon, Sep 14, 2020 at 05:43:56PM +0300, Roman Khabibov wrote:
> Hi, Cyrill and Igor!
>
> I tried to compare the addresses of the previous and the current iteration,
> if they are equal, then throw "looks like recursion, bad function!”. But I
> got swim tests failing. That is, they use some recursive serializers that do
> not overflow the stack. Therefore, I settled on the idea of introducing a
> recursion limit.
Look ok to me, I already gave an ack.
next prev parent reply other threads:[~2020-09-14 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 12:01 Roman Khabibov
2020-07-10 12:29 ` Cyrill Gorcunov
2020-07-14 9:45 ` Igor Munkin
2020-07-14 10:40 ` Cyrill Gorcunov
2020-09-14 14:43 ` Roman Khabibov
2020-09-14 16:06 ` Cyrill Gorcunov [this message]
2020-09-16 7:29 ` Igor Munkin
2020-09-30 21:49 ` Roman Khabibov
2020-10-01 14:40 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914160610.GD991329@grain \
--to=gorcunov@gmail.com \
--cc=roman.habibov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] serilaizer: check for recursive serialization' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox