From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [Tarantool-patches] [PATCH 1/3] cmake: ignore warnings on alignof() and offsetof() Date: Fri, 11 Sep 2020 14:24:29 +0300 [thread overview] Message-ID: <20200911112431.866554-2-gorcunov@gmail.com> (raw) In-Reply-To: <20200911112431.866554-1-gorcunov@gmail.com> From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Warning about invalid offsetof() (used on non-POD types) was set for g++, but wasn't for clang++. Warning about invalid alignof() (when expression is passed to it instead of a type) wasn't ignored, but is going to be very useful in upcoming unaligned memory access patches. That allows to write something like: struct some_long_type *object = region_aligned_alloc( region, size, alignof(*object)); This will work even if type of 'object' will change in future, and so it is safer. And shorter. Part of #4609 --- cmake/compiler.cmake | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cmake/compiler.cmake b/cmake/compiler.cmake index 56429dc20..b0908f3b3 100644 --- a/cmake/compiler.cmake +++ b/cmake/compiler.cmake @@ -276,11 +276,17 @@ macro(enable_tnt_compile_flags) add_compile_flags("C;CXX" "-Wno-format-truncation") endif() - if (CMAKE_COMPILER_IS_GNUCXX) + if (CMAKE_COMPILER_IS_CLANG OR CMAKE_COMPILER_IS_GNUCXX) # G++ bug. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31488 + # Also offsetof() is widely used in Tarantool source code + # for classes and structs to implement intrusive lists and + # some other data structures. G++ and clang++ both + # complain about classes, having a virtual table. They + # complain fair, but this can't be fixed for now. add_compile_flags("CXX" "-Wno-invalid-offsetof" ) + add_compile_flags("C;CXX" "-Wno-gnu-alignof-expression") endif() if (CMAKE_COMPILER_IS_GNUCC) -- 2.26.2
next prev parent reply other threads:[~2020-09-11 11:24 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-11 11:24 [Tarantool-patches] [PATCH 0/3] small: Update to use region_alloc_object Cyrill Gorcunov 2020-09-11 11:24 ` Cyrill Gorcunov [this message] 2020-09-11 11:24 ` [Tarantool-patches] [PATCH 2/3] Prepare for small library update Cyrill Gorcunov 2020-09-11 11:24 ` [Tarantool-patches] [PATCH 3/3] small: sanitized rlist, bug in lsregion, and new region API Cyrill Gorcunov 2020-09-14 16:07 ` [Tarantool-patches] [PATCH 0/3] small: Update to use region_alloc_object Cyrill Gorcunov 2020-09-15 13:50 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200911112431.866554-2-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 1/3] cmake: ignore warnings on alignof() and offsetof()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox