From: Kirill Yukhin <kyukhin@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] test: flaky replication/wal_off.test.lua test
Date: Fri, 11 Sep 2020 13:37:17 +0300 [thread overview]
Message-ID: <20200911103717.ivj3ilw56luabm7a@tarantool.org> (raw)
In-Reply-To: <bda73285fb38db64c6e1d91111edd0682b390a60.1599565740.git.avtikhon@tarantool.org>
Hello,
On 08 сен 14:50, Alexander V. Tikhonov wrote:
> On heavy loaded hosts found the following issue:
>
> [035] --- replication/wal_off.result Fri Jul 3 04:29:56 2020
> [035] +++ replication/wal_off.reject Mon Sep 7 15:32:46 2020
> [035] @@ -47,6 +47,8 @@
> [035] ...
> [035] while box.info.replication[wal_off_id].upstream.message ~= check do fiber.sleep(0) end
> [035] ---
> [035] +- error: '[string "while box.info.replication[wal_off_id].upstre..."]:1: attempt to
> [035] + index field ''upstream'' (a nil value)'
> [035] ...
> [035] box.info.replication[wal_off_id].upstream ~= nil
> [035] ---
>
> It happened because replication upstream status check occurred too
> early, when its state was not set. To give the replication status
> check routine ability to reach the needed 'stopped' state, it need
> to wait for it using test_run:wait_upstream() routine.
>
> Closes #5278
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5278-repl-wal-off
> Issue: https://github.com/tarantool/tarantool/issues/5278
I've checked your patch into 1.10, 2.4, 2.5 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-09-11 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 11:50 Alexander V. Tikhonov
2020-09-09 15:45 ` Serge Petrenko
2020-09-11 10:37 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200911103717.ivj3ilw56luabm7a@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] test: flaky replication/wal_off.test.lua test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox