From: Kirill Yukhin <kyukhin@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Mergen Imeev <imeevma@gmail.com>, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] test: fix status at replication/misc*4424* test
Date: Wed, 9 Sep 2020 14:44:44 +0300 [thread overview]
Message-ID: <20200909114444.ex5idgyafzheekgk@tarantool.org> (raw)
In-Reply-To: <c9c6d67cd18cdabcd6a46d20f80afe7992869c89.1599142125.git.avtikhon@tarantool.org>
Hello,
On 03 сен 17:10, Alexander V. Tikhonov wrote:
> Fixed flaky status check:
>
> [016] @@ -73,11 +73,11 @@
> [016] ...
> [016] box.info.status
> [016] ---
> [016] -- running
> [016] +- orphan
> [016] ...
> [016] box.info.ro
> [016] ---
> [016] -- false
> [016] +- true
> [016] ...
> [016] box.cfg{ \
> [016] replication = {}, \
> [016]
>
> Test changed to use wait condition for the status check, which should
> be changed from 'orphan' to 'running'. On heavy loaded hosts it may
> spend some additional time, wait condition routine helped to fix it.
>
> Closes #5271
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4940-replication-misc
> Issue: https://github.com/tarantool/tarantool/issues/5271
LGTM.
I've checked your patch into 1.10, 2.4, 2.5 and master.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-09-09 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 14:10 Alexander V. Tikhonov
2020-09-03 14:15 ` Serge Petrenko
2020-09-09 11:44 ` Kirill Yukhin [this message]
2020-09-09 11:53 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909114444.ex5idgyafzheekgk@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=imeevma@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] test: fix status at replication/misc*4424* test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox