From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7D0FF469719 for ; Wed, 9 Sep 2020 14:44:45 +0300 (MSK) Date: Wed, 9 Sep 2020 14:44:44 +0300 From: Kirill Yukhin Message-ID: <20200909114444.ex5idgyafzheekgk@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v1] test: fix status at replication/misc*4424* test List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: Mergen Imeev , tarantool-patches@dev.tarantool.org Hello, On 03 сен 17:10, Alexander V. Tikhonov wrote: > Fixed flaky status check: > > [016] @@ -73,11 +73,11 @@ > [016] ... > [016] box.info.status > [016] --- > [016] -- running > [016] +- orphan > [016] ... > [016] box.info.ro > [016] --- > [016] -- false > [016] +- true > [016] ... > [016] box.cfg{ \ > [016] replication = {}, \ > [016] > > Test changed to use wait condition for the status check, which should > be changed from 'orphan' to 'running'. On heavy loaded hosts it may > spend some additional time, wait condition routine helped to fix it. > > Closes #5271 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4940-replication-misc > Issue: https://github.com/tarantool/tarantool/issues/5271 LGTM. I've checked your patch into 1.10, 2.4, 2.5 and master. -- Regards, Kirill Yukhin