[Tarantool-patches] [PATCH v1] test: remove asan suppression for unit/msgpack

[Tarantool-patches] [PATCH v1] test: remove asan suppression for unit/msgpack

[Alexander V. Tikhonov]

ASAN should the issue in msgpuck repository in file test/msgpack.c
which was the cause of the fail in unit/msgpack test. The issue
was fixed in msgpuck repository and ASAN suppression was removed
for it. Also removed skip condition file, which blocked the test
when it failed.

Part of #4360
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/asan-restore
Issue: https://github.com/tarantool/tarantool/issues/4360

 asan/asan.supp             | 4 ----
 src/lib/msgpuck            | 2 +-
 test/unit/msgpack.skipcond | 7 -------
 3 files changed, 1 insertion(+), 12 deletions(-)
 delete mode 100644 test/unit/msgpack.skipcond

diff --git a/asan/asan.supp b/asan/asan.supp
index 24cb0845a..95a662461 100644
--- a/asan/asan.supp
+++ b/asan/asan.supp
@@ -4,7 +4,3 @@
 # File format:
 #fun:*
 #src:*
-
-# !test: unit/msgpack.test
-# source: src/lib/msgpuck/test/msgpuck.c
-fun:test_mp_print
diff --git a/src/lib/msgpuck b/src/lib/msgpuck
index 3cc63d3d1..a843861f7 160000
--- a/src/lib/msgpuck
+++ b/src/lib/msgpuck
@@ -1 +1 @@
-Subproject commit 3cc63d3d1d17c022894d8fb095c5d3dc3ae270aa
+Subproject commit a843861f7124f257bbd505fac8dbfb5708ecc855
diff --git a/test/unit/msgpack.skipcond b/test/unit/msgpack.skipcond
deleted file mode 100644
index e46fd1088..000000000
--- a/test/unit/msgpack.skipcond
+++ /dev/null
@@ -1,7 +0,0 @@
-import os
-
-# Disabled at ASAN build due to issue #4360.
-if os.getenv("ASAN") == 'ON':
-    self.skip = 1
-
-# vim: set ft=python:
-- 
2.17.1

Re: [Tarantool-patches] [PATCH v1] test: remove asan suppression for unit/msgpack

[Kirill Yukhin]

Hello,

On 20 авг 11:05, Alexander V. Tikhonov wrote:
> ASAN should the issue in msgpuck repository in file test/msgpack.c
> which was the cause of the fail in unit/msgpack test. The issue
> was fixed in msgpuck repository and ASAN suppression was removed
> for it. Also removed skip condition file, which blocked the test
> when it failed.
> 
> Part of #4360
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/asan-restore
> Issue: https://github.com/tarantool/tarantool/issues/4360

LGTM.
I've checked your patch into 1.10, 2.4, 2.5 and master.

--
Regards, Kirill Yukhin