From: Kirill Yukhin <kyukhin@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] test: remove asan suppression for unit/msgpack
Date: Wed, 9 Sep 2020 14:36:37 +0300 [thread overview]
Message-ID: <20200909113637.vgcsu4wohiz7cst7@tarantool.org> (raw)
In-Reply-To: <87c28236a265e7ab43072bc89b0a3a11339f7631.1597910696.git.avtikhon@tarantool.org>
Hello,
On 20 авг 11:05, Alexander V. Tikhonov wrote:
> ASAN should the issue in msgpuck repository in file test/msgpack.c
> which was the cause of the fail in unit/msgpack test. The issue
> was fixed in msgpuck repository and ASAN suppression was removed
> for it. Also removed skip condition file, which blocked the test
> when it failed.
>
> Part of #4360
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/asan-restore
> Issue: https://github.com/tarantool/tarantool/issues/4360
LGTM.
I've checked your patch into 1.10, 2.4, 2.5 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-09-09 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 8:05 Alexander V. Tikhonov
2020-09-09 11:36 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909113637.vgcsu4wohiz7cst7@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] test: remove asan suppression for unit/msgpack' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox