From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CA17D469719 for ; Wed, 9 Sep 2020 14:36:38 +0300 (MSK) Date: Wed, 9 Sep 2020 14:36:37 +0300 From: Kirill Yukhin Message-ID: <20200909113637.vgcsu4wohiz7cst7@tarantool.org> References: <87c28236a265e7ab43072bc89b0a3a11339f7631.1597910696.git.avtikhon@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87c28236a265e7ab43072bc89b0a3a11339f7631.1597910696.git.avtikhon@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v1] test: remove asan suppression for unit/msgpack List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Alexander V. Tikhonov" Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko Hello, On 20 авг 11:05, Alexander V. Tikhonov wrote: > ASAN should the issue in msgpuck repository in file test/msgpack.c > which was the cause of the fail in unit/msgpack test. The issue > was fixed in msgpuck repository and ASAN suppression was removed > for it. Also removed skip condition file, which blocked the test > when it failed. > > Part of #4360 > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/asan-restore > Issue: https://github.com/tarantool/tarantool/issues/4360 LGTM. I've checked your patch into 1.10, 2.4, 2.5 and master. -- Regards, Kirill Yukhin