From: Kirill Yukhin <kyukhin@tarantool.org>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] msgpack: print mp_exp type as signed integer
Date: Tue, 8 Sep 2020 17:51:21 +0300 [thread overview]
Message-ID: <20200908145121.o6fi6fdjqjltae4f@tarantool.org> (raw)
In-Reply-To: <20200901103143.31898-1-i.kosarev@tarantool.org>
Hello,
On 01 сен 13:31, Ilya Kosarev wrote:
> MsgPack extension types allow applications to define
> application-specific types. They consist of an 8-bit signed integer and
> a byte array where the integer represents a kind of types and the byte
> array represents data. Types from 0 to 127 are application-specific
> types and types from -128 to -1 are reserved for predefined types.
> However, extension types were printed as unsigned integers. Now it is
> fixed and extension types are being printed in a correct way as signed
> integers. Also the typo in word "Unsupported" was fixed. According test
> case is introduced.
>
> Closes #5016
> ---
> Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-5016-fix-extension-decoding
> Issue: https://github.com/tarantool/tarantool/issues/5016
I've checked your patch into 2.4, 2.5 and master.
--
Regards, Kirill Yukhin
next prev parent reply other threads:[~2020-09-08 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 10:31 Ilya Kosarev
2020-09-03 8:07 ` Aleksandr Lyapunov
2020-09-08 14:51 ` Kirill Yukhin [this message]
2020-09-04 13:55 Ilya Kosarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908145121.o6fi6fdjqjltae4f@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] msgpack: print mp_exp type as signed integer' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox