From: Alexander Turenko <alexander.turenko@tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] src: return back import of table.clear() method
Date: Tue, 1 Sep 2020 16:57:23 +0300 [thread overview]
Message-ID: <20200901135723.ao2d5xc4hl5rcert@tkn_work_nb> (raw)
In-Reply-To: <20200831111424.GC94343@pony.bronevichok.ru>
LGTM except one nit (no need to re-review with me):
Please, remove the changelog entry from the commit message. It is for
release notes and should be placed in a cover letter (or under --- for a
singleton patchset). There are cons and pros, but current process is so.
WBR, Alexander Turenko.
next prev parent reply other threads:[~2020-09-01 13:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 13:52 [Tarantool-patches] [PATCH 0/2] Recover " sergeyb
2020-07-28 13:52 ` [Tarantool-patches] [PATCH 1/2] src: return back import " sergeyb
2020-07-28 16:41 ` Alexander Turenko
2020-08-31 11:14 ` Sergey Bronnikov
2020-09-01 13:57 ` Alexander Turenko [this message]
2020-08-12 13:03 ` Oleg Babin
2020-08-31 11:18 ` Sergey Bronnikov
2020-07-28 13:52 ` [Tarantool-patches] [PATCH 2/2] test: add regression test for table.clear() sergeyb
2020-07-28 16:41 ` Alexander Turenko
2020-08-31 11:20 ` Sergey Bronnikov
2020-07-28 16:41 ` [Tarantool-patches] [PATCH 0/2] Recover of table.clear() method Alexander Turenko
2020-09-02 9:49 ` Sergey Bronnikov
2020-09-08 13:25 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901135723.ao2d5xc4hl5rcert@tkn_work_nb \
--to=alexander.turenko@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] src: return back import of table.clear() method' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox