From: Igor Munkin <imun@tarantool.org> To: Sergey Ostanevich <sergos@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v2 1/2] core: introduce various platform metrics Date: Thu, 27 Aug 2020 21:42:19 +0300 [thread overview] Message-ID: <20200827184219.GC18920@tarantool.org> (raw) In-Reply-To: <20200826155207.GA49@tarantool.org> Sergos, On 26.08.20, Sergey Ostanevich wrote: > On 26 авг 17:48, Igor Munkin wrote: <snipped> > > > > Furthermore, please address the comments I left regarding the patch > > you've made for CNEW IR[1] and squash it with this one. > > > > Sergos, do we need other JIT architectures to be patched in scope of > > this series or Sergey can just add the corresponding preprocessor > > condition to stub the issue for now? > > AFAU the CNEW IR appeared in src/lj_asm_x86.h so I didn't get what > preprocessor condition do you mean. Well, I clarify my point a bit: Sergey can implement cdata counter only for x86 platform both in compiler and interpreter. Other platforms will report nothing (i.e. zeros) for this metric and the issue can be fixed on demand. > Also, the inconsistency with the allocated CDATA counter will appear > anyways, so it needs to be implemented for other targets also. Looks > like a not-so-big deal? Yes, but I believe testing will take much more time than implementation. > BTW, AlexanderTi made a successful build and a little less successful > run on an ARM emulator that took some reasonable time. So there's a > way to test the change for ARM. Both PPC and MIPS I suppose would be > just fine to test for successful build. OK then, so I guess Sergey can make the patch for other arches as well. > > > > > > > [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-August/019012.html > > > > -- > > Best regards, > > IM -- Best regards, IM
next prev parent reply other threads:[~2020-08-27 18:52 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-26 20:40 [Tarantool-patches] [PATCH v2 0/2] Implement LuaJIT " Sergey Kaplun 2020-07-26 20:40 ` [Tarantool-patches] [PATCH v2 1/2] core: introduce various " Sergey Kaplun 2020-08-26 14:48 ` Igor Munkin 2020-08-26 15:52 ` Sergey Ostanevich 2020-08-27 18:42 ` Igor Munkin [this message] 2020-09-03 12:51 ` Sergey Kaplun 2020-07-26 20:40 ` [Tarantool-patches] [PATCH v2 2/2] metrics: add C and Lua API Sergey Kaplun 2020-08-27 18:25 ` Igor Munkin 2020-09-03 14:44 ` Sergey Kaplun 2020-09-03 15:22 ` Igor Munkin 2020-09-04 5:29 ` Sergey Kaplun 2020-07-26 20:42 ` [Tarantool-patches] [PATCH v2] rfc: luajit metrics Sergey Kaplun 2020-08-27 19:18 ` Igor Munkin 2020-09-03 12:57 ` Sergey Kaplun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200827184219.GC18920@tarantool.org \ --to=imun@tarantool.org \ --cc=sergos@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 1/2] core: introduce various platform metrics' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox