From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v9 4/7] qsync: direct write of CONFIRM/ROLLBACK into a journal
Date: Thu, 20 Aug 2020 10:13:21 +0300 [thread overview]
Message-ID: <20200820071321.GQ2074@grain> (raw)
In-Reply-To: <4c0358f3-130f-66d1-770d-c6659b6bbdbd@tarantool.org>
On Thu, Aug 20, 2020 at 12:43:45AM +0200, Vladislav Shpilevoy wrote:
> > + if (journal_write(entry) != 0 || entry->res < 0) {
> > + diag_set(ClientError, ER_WAL_IO);
> > + diag_log();
> > + /*
> > + * XXX: the stub is supposed to be removed once it is defined
> > + * what to do when a synchro request WAL write fails. One of
> > + * the possible solutions: log the error, keep the limbo
> > + * queue as is and probably put in rollback mode. Then
> > + * provide a hook to call manually when WAL problems are fixed.
> > + * Or retry automatically with some period.
> > + */
> > + panic("Could not write a synchro request to WAL: "
> > + "lsn = %lld, type = %s\n", lsn,
> > + type == IPROTO_CONFIRM ? "CONFIRM" : "ROLLBACK");
>
> Why did you inline iproto_type_name(type)?
It happened to sneak in from old commits (I've cherry picked it,
and there were no such code previously). I've fixed it and pushed
into the branch. Thanks for noticing!
next prev parent reply other threads:[~2020-08-20 7:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 21:34 [Tarantool-patches] [PATCH v9 0/7] qsync: write CONFIRM/ROLLBACK without txn engine Cyrill Gorcunov
2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 1/7] journal: bind asynchronous write completion to an entry Cyrill Gorcunov
2020-08-21 7:48 ` Serge Petrenko
2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 2/7] journal: add journal_entry_create helper Cyrill Gorcunov
2020-08-21 7:51 ` Serge Petrenko
2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 3/7] qsync: provide a binary form of syncro entries Cyrill Gorcunov
2020-08-21 8:15 ` Serge Petrenko
2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 4/7] qsync: direct write of CONFIRM/ROLLBACK into a journal Cyrill Gorcunov
2020-08-19 22:43 ` Vladislav Shpilevoy
2020-08-20 7:13 ` Cyrill Gorcunov [this message]
2020-08-21 8:36 ` Serge Petrenko
2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 5/7] applier: process synchro requests without txn engine Cyrill Gorcunov
2020-08-21 8:51 ` Serge Petrenko
2020-08-21 21:59 ` Vladislav Shpilevoy
2020-08-23 12:15 ` Serge Petrenko
2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 6/7] txn: txn_add_redo -- drop synchro processing Cyrill Gorcunov
2020-08-21 8:52 ` Serge Petrenko
2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 7/7] xrow: drop xrow_header_dup_body Cyrill Gorcunov
2020-08-21 8:57 ` Serge Petrenko
2020-08-24 21:16 ` [Tarantool-patches] [PATCH v9 0/7] qsync: write CONFIRM/ROLLBACK without txn engine Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820071321.GQ2074@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v9 4/7] qsync: direct write of CONFIRM/ROLLBACK into a journal' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox