From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [Tarantool-patches] [PATCH v9 7/7] xrow: drop xrow_header_dup_body Date: Thu, 20 Aug 2020 00:34:42 +0300 [thread overview] Message-ID: <20200819213442.1099018-8-gorcunov@gmail.com> (raw) In-Reply-To: <20200819213442.1099018-1-gorcunov@gmail.com> We no longer use it. Closes #5129 Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/box/xrow.c | 15 --------------- src/box/xrow.h | 8 -------- 2 files changed, 23 deletions(-) diff --git a/src/box/xrow.c b/src/box/xrow.c index 9c6fb4fc1..95ddb1fe7 100644 --- a/src/box/xrow.c +++ b/src/box/xrow.c @@ -220,21 +220,6 @@ xrow_header_decode(struct xrow_header *header, const char **pos, return 0; } -int -xrow_header_dup_body(struct xrow_header *row, struct region *region) -{ - assert(row->bodycnt == 1); - size_t size = row->body[0].iov_len; - char *copy = (char *)region_alloc(region, size); - if (copy == NULL) { - diag_set(OutOfMemory, size, "region_alloc", "copy"); - return -1; - } - memcpy(copy, row->body[0].iov_base, size); - row->body[0].iov_base = copy; - return 1; -} - /** * @pre pos points at a valid msgpack */ diff --git a/src/box/xrow.h b/src/box/xrow.h index 20e82034d..58d47b12d 100644 --- a/src/box/xrow.h +++ b/src/box/xrow.h @@ -141,14 +141,6 @@ int xrow_header_decode(struct xrow_header *header, const char **pos, const char *end, bool end_is_exact); -/** - * Duplicate the xrow's body onto the given region. - * @retval -1 Error. - * @retval >= 0 Iov count in the body. - */ -int -xrow_header_dup_body(struct xrow_header *header, struct region *region); - /** * DML request. */ -- 2.26.2
next prev parent reply other threads:[~2020-08-19 21:36 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-19 21:34 [Tarantool-patches] [PATCH v9 0/7] qsync: write CONFIRM/ROLLBACK without txn engine Cyrill Gorcunov 2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 1/7] journal: bind asynchronous write completion to an entry Cyrill Gorcunov 2020-08-21 7:48 ` Serge Petrenko 2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 2/7] journal: add journal_entry_create helper Cyrill Gorcunov 2020-08-21 7:51 ` Serge Petrenko 2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 3/7] qsync: provide a binary form of syncro entries Cyrill Gorcunov 2020-08-21 8:15 ` Serge Petrenko 2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 4/7] qsync: direct write of CONFIRM/ROLLBACK into a journal Cyrill Gorcunov 2020-08-19 22:43 ` Vladislav Shpilevoy 2020-08-20 7:13 ` Cyrill Gorcunov 2020-08-21 8:36 ` Serge Petrenko 2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 5/7] applier: process synchro requests without txn engine Cyrill Gorcunov 2020-08-21 8:51 ` Serge Petrenko 2020-08-21 21:59 ` Vladislav Shpilevoy 2020-08-23 12:15 ` Serge Petrenko 2020-08-19 21:34 ` [Tarantool-patches] [PATCH v9 6/7] txn: txn_add_redo -- drop synchro processing Cyrill Gorcunov 2020-08-21 8:52 ` Serge Petrenko 2020-08-19 21:34 ` Cyrill Gorcunov [this message] 2020-08-21 8:57 ` [Tarantool-patches] [PATCH v9 7/7] xrow: drop xrow_header_dup_body Serge Petrenko 2020-08-24 21:16 ` [Tarantool-patches] [PATCH v9 0/7] qsync: write CONFIRM/ROLLBACK without txn engine Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200819213442.1099018-8-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v9 7/7] xrow: drop xrow_header_dup_body' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox