From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [Tarantool-patches] [PATCH v8 3/9] journal: add journal_entry_create helper Date: Mon, 17 Aug 2020 16:39:12 +0300 [thread overview] Message-ID: <20200817133918.875558-4-gorcunov@gmail.com> (raw) In-Reply-To: <20200817133918.875558-1-gorcunov@gmail.com> To create raw journal entries. We will use it to write confirm/rollback entries. Part-of #5129 Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/box/journal.c | 8 ++------ src/box/journal.h | 16 ++++++++++++++++ 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/src/box/journal.c b/src/box/journal.c index 48af9157b..cb320b557 100644 --- a/src/box/journal.c +++ b/src/box/journal.c @@ -51,11 +51,7 @@ journal_entry_new(size_t n_rows, struct region *region, return NULL; } - entry->write_async_cb = write_async_cb; - entry->complete_data = complete_data; - entry->approx_len = 0; - entry->n_rows = n_rows; - entry->res = -1; - + journal_entry_create(entry, n_rows, 0, write_async_cb, + complete_data); return entry; } diff --git a/src/box/journal.h b/src/box/journal.h index 4b019fecf..5d8d5a726 100644 --- a/src/box/journal.h +++ b/src/box/journal.h @@ -83,6 +83,22 @@ struct journal_entry { struct region; +/** + * Initialize a new journal entry. + */ +static inline void +journal_entry_create(struct journal_entry *entry, size_t n_rows, + size_t approx_len, + journal_write_async_f write_async_cb, + void *complete_data) +{ + entry->write_async_cb = write_async_cb; + entry->complete_data = complete_data; + entry->approx_len = approx_len; + entry->n_rows = n_rows; + entry->res = -1; +} + /** * Create a new journal entry. * -- 2.26.2
next prev parent reply other threads:[~2020-08-17 13:39 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-17 13:39 [Tarantool-patches] [PATCH v8 0/9] qsync: write CONFIRM/ROLLBACK without txn engine Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 1/9] xrow: introduce struct synchro_request Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 2/9] journal: bind asynchronous write completion to an entry Cyrill Gorcunov 2020-08-17 13:39 ` Cyrill Gorcunov [this message] 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 4/9] qsync: provide a binary form of syncro entries Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 5/9] qsync: direct write of CONFIRM/ROLLBACK into a journal Cyrill Gorcunov 2020-08-17 20:49 ` Vladislav Shpilevoy 2020-08-17 22:16 ` Cyrill Gorcunov 2020-08-17 22:23 ` Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 6/9] applier: add shorthands to queue access Cyrill Gorcunov 2020-08-17 20:49 ` Vladislav Shpilevoy 2020-08-17 22:14 ` Cyrill Gorcunov 2020-08-18 19:18 ` Vladislav Shpilevoy 2020-08-19 20:37 ` Vladislav Shpilevoy 2020-08-19 20:49 ` Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 7/9] applier: process synchro requests without txn engine Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 8/9] txn: txn_add_redo -- drop synchro processing Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 9/9] xrow: drop xrow_header_dup_body Cyrill Gorcunov 2020-08-17 21:24 ` [Tarantool-patches] [PATCH v8 0/9] qsync: write CONFIRM/ROLLBACK without txn engine Vladislav Shpilevoy 2020-08-17 21:54 ` Cyrill Gorcunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200817133918.875558-4-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v8 3/9] journal: add journal_entry_create helper' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox