From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [Tarantool-patches] [PATCH v8 9/9] xrow: drop xrow_header_dup_body Date: Mon, 17 Aug 2020 16:39:18 +0300 [thread overview] Message-ID: <20200817133918.875558-10-gorcunov@gmail.com> (raw) In-Reply-To: <20200817133918.875558-1-gorcunov@gmail.com> We no longer use it. Closes #5129 Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- src/box/xrow.c | 15 --------------- src/box/xrow.h | 8 -------- 2 files changed, 23 deletions(-) diff --git a/src/box/xrow.c b/src/box/xrow.c index 03a4abdda..9aa2fae00 100644 --- a/src/box/xrow.c +++ b/src/box/xrow.c @@ -220,21 +220,6 @@ xrow_header_decode(struct xrow_header *header, const char **pos, return 0; } -int -xrow_header_dup_body(struct xrow_header *row, struct region *region) -{ - assert(row->bodycnt == 1); - size_t size = row->body[0].iov_len; - char *copy = (char *)region_alloc(region, size); - if (copy == NULL) { - diag_set(OutOfMemory, size, "region_alloc", "copy"); - return -1; - } - memcpy(copy, row->body[0].iov_base, size); - row->body[0].iov_base = copy; - return 1; -} - /** * @pre pos points at a valid msgpack */ diff --git a/src/box/xrow.h b/src/box/xrow.h index 20e82034d..58d47b12d 100644 --- a/src/box/xrow.h +++ b/src/box/xrow.h @@ -141,14 +141,6 @@ int xrow_header_decode(struct xrow_header *header, const char **pos, const char *end, bool end_is_exact); -/** - * Duplicate the xrow's body onto the given region. - * @retval -1 Error. - * @retval >= 0 Iov count in the body. - */ -int -xrow_header_dup_body(struct xrow_header *header, struct region *region); - /** * DML request. */ -- 2.26.2
next prev parent reply other threads:[~2020-08-17 13:41 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-17 13:39 [Tarantool-patches] [PATCH v8 0/9] qsync: write CONFIRM/ROLLBACK without txn engine Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 1/9] xrow: introduce struct synchro_request Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 2/9] journal: bind asynchronous write completion to an entry Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 3/9] journal: add journal_entry_create helper Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 4/9] qsync: provide a binary form of syncro entries Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 5/9] qsync: direct write of CONFIRM/ROLLBACK into a journal Cyrill Gorcunov 2020-08-17 20:49 ` Vladislav Shpilevoy 2020-08-17 22:16 ` Cyrill Gorcunov 2020-08-17 22:23 ` Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 6/9] applier: add shorthands to queue access Cyrill Gorcunov 2020-08-17 20:49 ` Vladislav Shpilevoy 2020-08-17 22:14 ` Cyrill Gorcunov 2020-08-18 19:18 ` Vladislav Shpilevoy 2020-08-19 20:37 ` Vladislav Shpilevoy 2020-08-19 20:49 ` Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 7/9] applier: process synchro requests without txn engine Cyrill Gorcunov 2020-08-17 13:39 ` [Tarantool-patches] [PATCH v8 8/9] txn: txn_add_redo -- drop synchro processing Cyrill Gorcunov 2020-08-17 13:39 ` Cyrill Gorcunov [this message] 2020-08-17 21:24 ` [Tarantool-patches] [PATCH v8 0/9] qsync: write CONFIRM/ROLLBACK without txn engine Vladislav Shpilevoy 2020-08-17 21:54 ` Cyrill Gorcunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200817133918.875558-10-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v8 9/9] xrow: drop xrow_header_dup_body' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox