From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] applier: drop a couple of unnecessary arguments
Date: Mon, 17 Aug 2020 11:02:34 +0300 [thread overview]
Message-ID: <20200817080234.GH2074@grain> (raw)
In-Reply-To: <7e16e45e171cb34edaff69b0f660421f1b67b4a1.1597504571.git.v.shpilevoy@tarantool.org>
On Sat, Aug 15, 2020 at 05:16:44PM +0200, Vladislav Shpilevoy wrote:
> Applier on_rollback and on_wal_write don't need any arguments -
> they either work with a global state, or with the signaled applier
> stored inside the trigger.
>
> However into on_wal_write() and on_rollback() was passed the
> transaction object, unused.
>
> Even if it would be used, it should have been fixed, because soon
> these triggers will be fired not only for traditional 'txn'
> transactions. They will be used by the synchro request WAL writes
> too - they don't have 'transactions'.
>
> Part of #5129
> ---
Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>
next prev parent reply other threads:[~2020-08-17 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 15:16 Vladislav Shpilevoy
2020-08-17 8:02 ` Cyrill Gorcunov [this message]
2020-08-17 20:22 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817080234.GH2074@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] applier: drop a couple of unnecessary arguments' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox