From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v7 5/8] applier: factor out latch locking
Date: Sat, 15 Aug 2020 19:27:00 +0300 [thread overview]
Message-ID: <20200815162700.GG2074@grain> (raw)
In-Reply-To: <0da9d013-6b94-fc4d-17d4-379dcf51bbed@tarantool.org>
On Sat, Aug 15, 2020 at 05:04:32PM +0200, Vladislav Shpilevoy wrote:
> > +static inline struct latch *
> > +applier_lock(uint32_t replica_id)
> > +{
> > + struct replica *replica = replica_by_id(replica_id);
> > + struct latch *latch = (replica ? &replica->order_latch :
>
> We usually use != NULL to check if a pointer is not NULL. To emphasize
> it is not a boolean variable in the code.
I simply copied this code from old place. But sure, will add.
next prev parent reply other threads:[~2020-08-15 16:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 21:14 [Tarantool-patches] [PATCH v7 0/8] qsync: write CONFIRM/ROLLBACK without txn engine Cyrill Gorcunov
2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 1/8] journal: bind asynchronous write completion to an entry Cyrill Gorcunov
2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 2/8] journal: add journal_entry_create helper Cyrill Gorcunov
2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 3/8] qsync: provide a binary form of syncro entries Cyrill Gorcunov
2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 4/8] qsync: direct write of CONFIRM/ROLLBACK into a journal Cyrill Gorcunov
2020-08-15 15:04 ` Vladislav Shpilevoy
2020-08-15 16:26 ` Cyrill Gorcunov
2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 5/8] applier: factor out latch locking Cyrill Gorcunov
2020-08-15 15:04 ` Vladislav Shpilevoy
2020-08-15 16:27 ` Cyrill Gorcunov [this message]
2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 6/8] applier: add shorthands to queue access Cyrill Gorcunov
2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 7/8] applier: process synchro requests without txn engine Cyrill Gorcunov
2020-08-15 15:06 ` Vladislav Shpilevoy
2020-08-17 12:42 ` Cyrill Gorcunov
2020-08-17 20:49 ` Vladislav Shpilevoy
2020-08-18 8:08 ` Cyrill Gorcunov
2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 8/8] applier: drop process_synchro_row Cyrill Gorcunov
2020-08-15 8:38 ` [Tarantool-patches] [PATCH v7 9/8] txn: txn_add_redo -- drop synchro processing Cyrill Gorcunov
2020-08-15 15:06 ` Vladislav Shpilevoy
2020-08-17 8:03 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200815162700.GG2074@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v7 5/8] applier: factor out latch locking' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox