From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [Tarantool-patches] [PATCH v7 9/8] txn: txn_add_redo -- drop synchro processing Date: Sat, 15 Aug 2020 11:38:51 +0300 [thread overview] Message-ID: <20200815083851.GD2074@grain> (raw) In-Reply-To: <20200814211442.667099-1-gorcunov@gmail.com> Since we no longer use txn engine for synchro packets processing this code is never executed. Part-of #5129 Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> --- Happen to miss this yesterday. I pushed into the same branch. src/box/txn.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/box/txn.c b/src/box/txn.c index cc1f496c5..b2d342355 100644 --- a/src/box/txn.c +++ b/src/box/txn.c @@ -82,14 +82,7 @@ txn_add_redo(struct txn *txn, struct txn_stmt *stmt, struct request *request) */ struct space *space = stmt->space; row->group_id = space != NULL ? space_group_id(space) : 0; - /* - * Sychronous replication entries are supplementary and - * aren't valid dml requests. They're encoded manually. - */ - if (likely(!iproto_type_is_synchro_request(row->type))) - row->bodycnt = xrow_encode_dml(request, &txn->region, row->body); - else - row->bodycnt = xrow_header_dup_body(row, &txn->region); + row->bodycnt = xrow_encode_dml(request, &txn->region, row->body); if (row->bodycnt < 0) return -1; stmt->row = row; -- 2.26.2
next prev parent reply other threads:[~2020-08-15 8:38 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-14 21:14 [Tarantool-patches] [PATCH v7 0/8] qsync: write CONFIRM/ROLLBACK without txn engine Cyrill Gorcunov 2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 1/8] journal: bind asynchronous write completion to an entry Cyrill Gorcunov 2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 2/8] journal: add journal_entry_create helper Cyrill Gorcunov 2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 3/8] qsync: provide a binary form of syncro entries Cyrill Gorcunov 2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 4/8] qsync: direct write of CONFIRM/ROLLBACK into a journal Cyrill Gorcunov 2020-08-15 15:04 ` Vladislav Shpilevoy 2020-08-15 16:26 ` Cyrill Gorcunov 2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 5/8] applier: factor out latch locking Cyrill Gorcunov 2020-08-15 15:04 ` Vladislav Shpilevoy 2020-08-15 16:27 ` Cyrill Gorcunov 2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 6/8] applier: add shorthands to queue access Cyrill Gorcunov 2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 7/8] applier: process synchro requests without txn engine Cyrill Gorcunov 2020-08-15 15:06 ` Vladislav Shpilevoy 2020-08-17 12:42 ` Cyrill Gorcunov 2020-08-17 20:49 ` Vladislav Shpilevoy 2020-08-18 8:08 ` Cyrill Gorcunov 2020-08-14 21:14 ` [Tarantool-patches] [PATCH v7 8/8] applier: drop process_synchro_row Cyrill Gorcunov 2020-08-15 8:38 ` Cyrill Gorcunov [this message] 2020-08-15 15:06 ` [Tarantool-patches] [PATCH v7 9/8] txn: txn_add_redo -- drop synchro processing Vladislav Shpilevoy 2020-08-17 8:03 ` Cyrill Gorcunov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200815083851.GD2074@grain \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v7 9/8] txn: txn_add_redo -- drop synchro processing' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox