From: Kirill Yukhin <kyukhin@tarantool.org>
To: Yaroslav Dynnikov <yaroslav.dynnikov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] Ensure all curl symbols are exported
Date: Thu, 13 Aug 2020 14:48:59 +0300 [thread overview]
Message-ID: <20200813114859.axmmoc7z2c227v6j@tarantool.org> (raw)
In-Reply-To: <20200806131955.3400088-1-yaroslav.dynnikov@tarantool.org>
Hello,
On 06 авг 16:19, Yaroslav Dynnikov wrote:
> In the recent update of libcurl (2.5.0-278-g807c7fa58) its layout has
> changed: private function `Curl_version_init()` which used to fill-in
> info structure was eliminated. As a result, no symbols for
> `libcurl_la-version.o` remained used, so it wasn't included in tarantool
> binary. And `curl_version` and `curl_version_info` symbols went missing.
>
> According to libcurl naming conventions all exported symbols are named
> as `curl_*`. This patch lists them all explicitly in `exprots.h` and
> adds the test.
>
> Close #5223
>
> Issue: https://github.com/tarantool/tarantool/issues/5223
> Branch: https://github.com/tarantool/tarantool/tree/rosik/gh-5223-missing-curl-symbols
I've checked your patch into master.
In future, could you please append a Relase Notes entry to your patches.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-08-13 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 13:19 Yaroslav Dynnikov
2020-08-06 15:06 ` Timur Safin
2020-08-10 22:49 ` Vladislav Shpilevoy
2020-08-12 12:59 ` Yaroslav Dynnikov
2020-08-12 20:10 ` Vladislav Shpilevoy
2020-08-13 11:48 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813114859.axmmoc7z2c227v6j@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=yaroslav.dynnikov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Ensure all curl symbols are exported' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox