From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] box: snapshot should not include rolled back data
Date: Tue, 11 Aug 2020 10:53:20 +0300 [thread overview]
Message-ID: <20200811075320.GA2074@grain> (raw)
In-Reply-To: <6fc5876bfde067f19973a5d701b55bf4826f2a9e.1597097775.git.v.shpilevoy@tarantool.org>
On Tue, Aug 11, 2020 at 12:18:05AM +0200, Vladislav Shpilevoy wrote:
> Box.snapshot() could include rolled back data in case synchronous
> transaction ROLLBACK arrived during WAL rotation in preparation of
> a checkpoint.
>
> More specifically, snapshot consists of fixating the engines'
> content (creation of a read-view), doing WAL rotation, and writing
> the snapshot itself. All data changes after content fixation won't
> go into the snap. So if ROLLBACK arrives during WAL rotation, the
> fixated content will have rolled back data, not present in the
> newest dataset.
>
> The patch makes it fail if during WAL rotation anything was rolled
> back. The bug sometimes appeared in an existing test about qsync
> snapshots, but with a very poor reproducibility. In a new test
> file it is reproduced 100% without the patch.
>
> Closes #5167
Ack. Lets give it a shot.
next prev parent reply other threads:[~2020-08-11 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 22:18 Vladislav Shpilevoy
2020-08-11 7:53 ` Cyrill Gorcunov [this message]
2020-08-11 12:32 ` Serge Petrenko
2020-08-11 23:01 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811075320.GA2074@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] box: snapshot should not include rolled back data' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox