Re: [Tarantool-patches] [PATCH] tuple: drop extra restrictions for multikey index

[Nikita Pettik <korablev@tarantool.org>]

On 31 Jul 16:13, Ilya Kosarev wrote:
> 
> Hi!
>  
> Thanks for your review.
>  
> See my answers below.
>  
> I will send v2 of the patch but i think 2 questions above should be clarified.
>   
> >Четверг, 30 июля 2020, 17:26 +03:00 от Nikita Pettik <korablev@tarantool.org>:
> > 
> >On 24 Jul 23:06, Ilya Kosarev wrote:
> >
> >I *strongly dislike* that the patch is in fact should be 10 lines
> >but instead we have 250 diff lines. Please elaborate on that
> >(comments above are mostly about that).
> Well, this patch reverts the majority of changes from
> 4cf94ef8cb90b84ea71f313cff3e016f85894fd5 (tuple: make fields nullable
> by default except array/map). That is where the size comes from.

Then you are able simply to revert that patch and introduce new one.
But I'd provide only required fixes.

> >> diff --git a/src/box/memtx_space.c b/src/box/memtx_space.c
> >> index 8452ab430..875592026 100644
> >> --- a/src/box/memtx_space.c
> >> +++ b/src/box/memtx_space.c
> >> @@ -589,9 +589,7 @@ memtx_space_ephemeral_rowid_next(struct space *space, uint64_t *rowid)
> >> static int
> >> memtx_space_check_index_def(struct space *space, struct index_def *index_def)
> >> {
> >> - struct key_def *key_def = index_def->key_def;
> >> -
> >> - if (key_def->is_nullable) {
> >> + if (index_def->key_def->is_nullable) {
> >
> >Again I see this redundant diff. Please drop it, it doesn't fix
> >refactor/fix anything but makes diff bigger and complicates git
> >history.
> The problem is that this is the reversion of that diff. Well, I guess
> as far as that patch was pushed to master we can leave that change
> there and revert only the meaningful part?

Yes.