Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] txn_limbo: panic when synchro WAL write fails
Date: Thu, 30 Jul 2020 11:49:39 +0300	[thread overview]
Message-ID: <20200730084939.GF3264@grain> (raw)
In-Reply-To: <04de5b4a0f7859909155cb9f52e9fd45a338a0e8.1596065870.git.v.shpilevoy@tarantool.org>

On Thu, Jul 30, 2020 at 01:39:05AM +0200, Vladislav Shpilevoy wrote:
> CONFIRM and ROLLBACK go to WAL. Their WAL write can fail just like
> any other WAL write. However it is not clear what to do in that
> case, especially in case of ROLLBACK fail.
> 
> The patch adds panic() stub so as to at least terminate the
> instance. Before the patch it would work like nothing happened,
> with undefined behaviour.
> 
> Closes #5159

This bunch of panicings is priceless :-) We _are_ to make some
more sane handling in near future. For a while this is fine.

Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>

  reply	other threads:[~2020-07-30  8:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 23:39 Vladislav Shpilevoy
2020-07-30  8:49 ` Cyrill Gorcunov [this message]
2020-07-30 19:57 ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730084939.GF3264@grain \
    --to=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1/1] txn_limbo: panic when synchro WAL write fails' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox