From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] txn_limbo: reduce fiber_set_cancellable() calls
Date: Thu, 30 Jul 2020 11:47:45 +0300 [thread overview]
Message-ID: <20200730084745.GE3264@grain> (raw)
In-Reply-To: <a6ab37710e81ff1fe51efa897631aee7c0efc506.1596066060.git.v.shpilevoy@tarantool.org>
On Thu, Jul 30, 2020 at 01:41:20AM +0200, Vladislav Shpilevoy wrote:
> The calls were added before and after each cond_wait() so as the
> fiber couldn't be woken up externally. For example, from Lua.
>
> But it is not necessary to flip the flag on each wait() call. It
> is enough to make it 2 times: forbid cancellation in the beginning
> of txn_limbo_wait_complete(), and return the old value back in the
> end.
> ---
Ack
next prev parent reply other threads:[~2020-07-30 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 23:41 Vladislav Shpilevoy
2020-07-30 8:47 ` Cyrill Gorcunov [this message]
2020-07-30 19:57 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730084745.GE3264@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] txn_limbo: reduce fiber_set_cancellable() calls' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox