From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] txn_limbo: don't duplicate confirmations in WAL
Date: Wed, 29 Jul 2020 23:06:56 +0300 [thread overview]
Message-ID: <20200729200656.GC3264@grain> (raw)
In-Reply-To: <a7e401dbb261883515be221c55c55e7b6f34e4aa.1595978179.git.v.shpilevoy@tarantool.org>
On Wed, Jul 29, 2020 at 01:17:27AM +0200, Vladislav Shpilevoy wrote:
> When an ACK was received for an already confirmed transaction
> whose CONFIRM WAL write is in progress, it produced a second
> CONFIRM in WAL with the same LSN.
>
> That was unnecessary work taking time and disk space for WAL
> records. Although it didn't lead to any bugs. Just was very
> inefficient.
>
> This patch makes confirmation LSN monotonically grow. In case more
> ACKs are received for an already confirmed LSN, its confirmation
> is not written second time.
>
> Closes #5144
Ack
next prev parent reply other threads:[~2020-07-29 20:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 23:17 Vladislav Shpilevoy
2020-07-29 20:06 ` Cyrill Gorcunov [this message]
2020-07-29 20:54 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729200656.GC3264@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] txn_limbo: don'\''t duplicate confirmations in WAL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox