From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ilya Kosarev <i.kosarev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/2] fiber: set diagnostics at madvise/mprotect failure
Date: Wed, 29 Jul 2020 20:04:54 +0300 [thread overview]
Message-ID: <20200729170454.GA3264@grain> (raw)
In-Reply-To: <482137955bbc7004f23e5c3ffb7d65b3ab0e223f.1596040943.git.i.kosarev@tarantool.org>
On Wed, Jul 29, 2020 at 07:50:41PM +0300, Ilya Kosarev wrote:
>
> /**
> * Injection state
> */
> struct errinj {
> - /** Name, e.g "ERRINJ_WAL_WRITE" */
> - const char *name;
> - /** Type, e.g. BOOL, U64, DOUBLE */
> - enum errinj_type type;
> - union {
> - /** bool parameter */
> - bool bparam;
> - /** integer parameter */
> - int64_t iparam;
> + /** Name, e.g "ERRINJ_WAL_WRITE" */
> + const char *name;
> + /** Type, e.g. BOOL, U64, DOUBLE */
> + enum errinj_type type;
Ilya, the whole patch is tabs/space screwed. Is is supposed to be so?
next prev parent reply other threads:[~2020-07-29 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 16:50 [Tarantool-patches] [PATCH 0/2] fiber: backport for stack madvise/mprotect errors handling Ilya Kosarev
2020-07-29 16:50 ` [Tarantool-patches] [PATCH 1/2] fiber: set diagnostics at madvise/mprotect failure Ilya Kosarev
2020-07-29 17:04 ` Cyrill Gorcunov [this message]
2020-07-29 16:50 ` [Tarantool-patches] [PATCH 2/2] fiber: leak slab if unable to bring prots back Ilya Kosarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729170454.GA3264@grain \
--to=gorcunov@gmail.com \
--cc=i.kosarev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/2] fiber: set diagnostics at madvise/mprotect failure' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox