[Tarantool-patches] [PATCH v1] gitlab-ci: restore lto testing on OSX

[Tarantool-patches] [PATCH v1] gitlab-ci: restore lto testing on OSX

[Alexander V. Tikhonov]

Found that after commit:

  7faa1abe2b2dedd3a5d2971ddd7c5b9ce55c30b2 "gitlab-ci: implement OSX 10.14 testing on mac mini"

the variable environment CMAKE_EXTRA_PARAMS, which turns on LTO flag
on OSX compilation was mistakenly missed to be updated and LTO feature
was disabled on OSX testing in real.

After it later commit:

  a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5 "lua/log: add ability to configure logging early"

added the missed LTO error, which was fixed at:

  625095d95c5d1962c02c124fcba098e527f017fd "lua/log: add missing exports"

Closes #5160
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5160-restore-osx-lto
Issue: https://github.com/tarantool/tarantool/issues/5160

 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 580825005..0ead08711 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -194,7 +194,7 @@ osx_15_release_lto:
   tags:
     - osx_15
   variables:
-    EXTRA_ENV: 'export CMAKE_EXTRA_PARAMS=-DENABLE_LTO=ON ;'
+    CMAKE_EXTRA_PARAMS: -DENABLE_LTO=ON
   <<: *osx_definition
 
 freebsd_12_release:
-- 
2.17.1

Re: [Tarantool-patches] [PATCH v1] gitlab-ci: restore lto testing on OSX

[Kirill Yukhin]

Hello,

On 28 июл 18:09, Alexander V. Tikhonov wrote:
> Found that after commit:
> 
>   7faa1abe2b2dedd3a5d2971ddd7c5b9ce55c30b2 "gitlab-ci: implement OSX 10.14 testing on mac mini"
> 
> the variable environment CMAKE_EXTRA_PARAMS, which turns on LTO flag
> on OSX compilation was mistakenly missed to be updated and LTO feature
> was disabled on OSX testing in real.
> 
> After it later commit:
> 
>   a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5 "lua/log: add ability to configure logging early"
> 
> added the missed LTO error, which was fixed at:
> 
>   625095d95c5d1962c02c124fcba098e527f017fd "lua/log: add missing exports"
> 
> Closes #5160

LGTM.
I've checked your patch into 1.10 2.4 2.5 and master.

--
Regards, Kirill Yukhin