From: Kirill Yukhin <kyukhin@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] lua/log: add missing exports
Date: Tue, 28 Jul 2020 17:08:02 +0300 [thread overview]
Message-ID: <20200728140801.qeb2nwexxbpl6ves@tarantool.org> (raw)
In-Reply-To: <20200728132742.504810-1-gorcunov@gmail.com>
Hello,
On 28 июл 16:27, Cyrill Gorcunov wrote:
> When building with LTO non exported symbols might
> be discarded while we have implicit use in log.lua
> code.
>
> Introduced by a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5
>
> Fixes #5160
LGTM.
I've checked your patch into 2.5 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-07-28 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 13:27 Cyrill Gorcunov
2020-07-28 13:48 ` Alexander V. Tikhonov
2020-07-28 13:52 ` Cyrill Gorcunov
2020-07-28 14:08 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728140801.qeb2nwexxbpl6ves@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] lua/log: add missing exports' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox