* [Tarantool-patches] [PATCH] lua/log: add missing exports
@ 2020-07-28 13:27 Cyrill Gorcunov
2020-07-28 13:48 ` Alexander V. Tikhonov
2020-07-28 14:08 ` Kirill Yukhin
0 siblings, 2 replies; 4+ messages in thread
From: Cyrill Gorcunov @ 2020-07-28 13:27 UTC (permalink / raw)
To: tml
When building with LTO non exported symbols might
be discarded while we have implicit use in log.lua
code.
Introduced by a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5
Fixes #5160
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
src/exports.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/exports.h b/src/exports.h
index fe3b31dba..7cf283e5b 100644
--- a/src/exports.h
+++ b/src/exports.h
@@ -350,6 +350,8 @@ EXPORT(PMurHash32_Result)
EXPORT(port_destroy)
EXPORT(random_bytes)
EXPORT(_say)
+EXPORT(say_logger_init)
+EXPORT(say_logger_initialized)
EXPORT(say_logrotate)
EXPORT(say_set_log_format)
EXPORT(say_set_log_level)
--
2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH] lua/log: add missing exports
2020-07-28 13:27 [Tarantool-patches] [PATCH] lua/log: add missing exports Cyrill Gorcunov
@ 2020-07-28 13:48 ` Alexander V. Tikhonov
2020-07-28 13:52 ` Cyrill Gorcunov
2020-07-28 14:08 ` Kirill Yukhin
1 sibling, 1 reply; 4+ messages in thread
From: Alexander V. Tikhonov @ 2020-07-28 13:48 UTC (permalink / raw)
To: Cyrill Gorcunov; +Cc: tarantool-patches
Hi Cyrill, I've checked your patch and it fixed LTO build on OSX.
Please proceed with it, patch LGTM.
On Tue, Jul 28, 2020 at 04:27:42PM +0300, Cyrill Gorcunov wrote:
> When building with LTO non exported symbols might
> be discarded while we have implicit use in log.lua
> code.
>
> Introduced by a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5
>
> Fixes #5160
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> src/exports.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/exports.h b/src/exports.h
> index fe3b31dba..7cf283e5b 100644
> --- a/src/exports.h
> +++ b/src/exports.h
> @@ -350,6 +350,8 @@ EXPORT(PMurHash32_Result)
> EXPORT(port_destroy)
> EXPORT(random_bytes)
> EXPORT(_say)
> +EXPORT(say_logger_init)
> +EXPORT(say_logger_initialized)
> EXPORT(say_logrotate)
> EXPORT(say_set_log_format)
> EXPORT(say_set_log_level)
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH] lua/log: add missing exports
2020-07-28 13:48 ` Alexander V. Tikhonov
@ 2020-07-28 13:52 ` Cyrill Gorcunov
0 siblings, 0 replies; 4+ messages in thread
From: Cyrill Gorcunov @ 2020-07-28 13:52 UTC (permalink / raw)
To: Alexander V. Tikhonov, Kirill Yukhin; +Cc: tarantool-patches
On Tue, Jul 28, 2020 at 04:48:37PM +0300, Alexander V. Tikhonov wrote:
> Hi Cyrill, I've checked your patch and it fixed LTO build on OSX.
> Please proceed with it, patch LGTM.
>
Thanks. Kirill, merge it please.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH] lua/log: add missing exports
2020-07-28 13:27 [Tarantool-patches] [PATCH] lua/log: add missing exports Cyrill Gorcunov
2020-07-28 13:48 ` Alexander V. Tikhonov
@ 2020-07-28 14:08 ` Kirill Yukhin
1 sibling, 0 replies; 4+ messages in thread
From: Kirill Yukhin @ 2020-07-28 14:08 UTC (permalink / raw)
To: Cyrill Gorcunov; +Cc: tml
Hello,
On 28 июл 16:27, Cyrill Gorcunov wrote:
> When building with LTO non exported symbols might
> be discarded while we have implicit use in log.lua
> code.
>
> Introduced by a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5
>
> Fixes #5160
LGTM.
I've checked your patch into 2.5 and master.
--
Regards, Kirill Yukhin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-28 14:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 13:27 [Tarantool-patches] [PATCH] lua/log: add missing exports Cyrill Gorcunov
2020-07-28 13:48 ` Alexander V. Tikhonov
2020-07-28 13:52 ` Cyrill Gorcunov
2020-07-28 14:08 ` Kirill Yukhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox