From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] lua/log: add missing exports
Date: Tue, 28 Jul 2020 16:48:37 +0300 [thread overview]
Message-ID: <20200728134837.GA8171@hpalx> (raw)
In-Reply-To: <20200728132742.504810-1-gorcunov@gmail.com>
Hi Cyrill, I've checked your patch and it fixed LTO build on OSX.
Please proceed with it, patch LGTM.
On Tue, Jul 28, 2020 at 04:27:42PM +0300, Cyrill Gorcunov wrote:
> When building with LTO non exported symbols might
> be discarded while we have implicit use in log.lua
> code.
>
> Introduced by a94a9b3fd629b5abbc99a23ba527cd91e5c6ebf5
>
> Fixes #5160
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> src/exports.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/exports.h b/src/exports.h
> index fe3b31dba..7cf283e5b 100644
> --- a/src/exports.h
> +++ b/src/exports.h
> @@ -350,6 +350,8 @@ EXPORT(PMurHash32_Result)
> EXPORT(port_destroy)
> EXPORT(random_bytes)
> EXPORT(_say)
> +EXPORT(say_logger_init)
> +EXPORT(say_logger_initialized)
> EXPORT(say_logrotate)
> EXPORT(say_set_log_format)
> EXPORT(say_set_log_level)
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-07-28 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 13:27 Cyrill Gorcunov
2020-07-28 13:48 ` Alexander V. Tikhonov [this message]
2020-07-28 13:52 ` Cyrill Gorcunov
2020-07-28 14:08 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728134837.GA8171@hpalx \
--to=avtikhon@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] lua/log: add missing exports' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox