From: Alexander Turenko <alexander.turenko@tarantool.org> To: "Alexander V. Tikhonov" <avtikhon@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v1] update_repo: correct fix for RPMs on missing metadata Date: Mon, 27 Jul 2020 17:18:40 +0300 [thread overview] Message-ID: <20200727141840.fisd4tim7fxel55u@tkn_work_nb> (raw) In-Reply-To: <9d538c87b2a0106b325c1ec104206a9f38f207df.1595855406.git.avtikhon@tarantool.org> On Mon, Jul 27, 2020 at 04:11:06PM +0300, Alexander V. Tikhonov wrote: > Found that removing RPMs additional call to its removement is > needed, when no metadata was found. > --- > > Github: https://github.com/tarantool/tarantool/tree/avtikhon/correct_rpm_remove > > tools/update_repo.sh | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/update_repo.sh b/tools/update_repo.sh > index 5a68e3e05..d9b91a753 100755 > --- a/tools/update_repo.sh > +++ b/tools/update_repo.sh > @@ -869,6 +869,13 @@ function remove_rpm { > done > done > > + # remove all found file by the given pattern in options I would describe the case a bit: the loop above already delete files, which are present in the metadata. However it is possible that some broken update left orphan files: they are present in the storage, but does not mentioned in the metadata. > + for suffix in 'x86_64' 'noarch' 'src'; do > + file="$bucket_path/$packpath/${remove}-1.${os}${option_dist}.${suffix}.rpm" > + $aws ls $file || continue > + $aws rm $file > + done > + I don't mind, however I'm unable to review the file thoroughly.
next prev parent reply other threads:[~2020-07-27 14:19 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-27 13:11 Alexander V. Tikhonov 2020-07-27 14:18 ` Alexander Turenko [this message] 2020-08-07 16:10 ` Alexander V. Tikhonov 2020-08-31 11:39 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200727141840.fisd4tim7fxel55u@tkn_work_nb \ --to=alexander.turenko@tarantool.org \ --cc=avtikhon@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1] update_repo: correct fix for RPMs on missing metadata' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox