From: Igor Munkin <imun@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3] lua: assert in lua_gettop() in case of negative stack size
Date: Wed, 22 Jul 2020 15:05:03 +0300 [thread overview]
Message-ID: <20200722120503.GO18920@tarantool.org> (raw)
In-Reply-To: <20200722110841.GB25532@tarantool.org>
Nikita,
On 22.07.20, Nikita Pettik wrote:
<snipped>
> >
> > For now I see no reason to add even the assert, since Ilya's assumptions
> > are confirmed.
>
> Which one? Assuming that lua_gettop() returns negative value due
> to spoiled lua state?
Yes, no need to check whether L->base is greater than L->top, it's
already known from the coredump. I doubt this change allows to localize
the problem much closer than now. Let's see customer's user code and
proceed with the investigation.
>
--
Best regards,
IM
prev parent reply other threads:[~2020-07-22 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 22:32 Ilya Kosarev
2020-07-22 8:59 ` Nikita Pettik
2020-07-22 9:46 ` Ilya Kosarev
2020-07-22 9:46 ` Igor Munkin
2020-07-22 10:25 ` Ilya Kosarev
2020-07-22 10:47 ` Igor Munkin
2020-07-22 11:08 ` Nikita Pettik
2020-07-22 12:05 ` Igor Munkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722120503.GO18920@tarantool.org \
--to=imun@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3] lua: assert in lua_gettop() in case of negative stack size' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox