Re: [Tarantool-patches] [PATCH v1] gitlab-ci: setup local cleanup/checkout processes

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 22 июл 13:17, Alexander V. Tikhonov wrote:
> Set cleanup based on docker for all of the jobs to avoid of fails
> when the job before change could use docker and reassigned the
> temporary files in the working directory. If the docker is not
> available than no need to use it for cleanup and cleanup runs
> using shell. Gitlab-ci clean flags disabled and reorganized localy
> as shown at [1].
> 
> Disabled gitlab-ci checkout default process as shown at [2] to be
> able to fix repository before the checkout. Found that previously
> run gitlab-ci jobs could change permissions files at repository
> which broke the checkouts at the next jobs. Used for checkout
> strategy [3], for submodule update strategy [4]. Submodules local
> update routine in .gitlab.mk file became unneeded and removed.
> 
> List of steps made localy instead of gitlab-ci preparations:
> 
> 1. Check/clone the Tarantool repository with submodules.
> 2. For shell based jobs change ownership of all the sources
>    to 'gitlab-runner' user. (NOTE: in Docker based jobs the
>    'gitlab-runner' user is not known.)
> 3. Fetch Tarantool sources with branches and force checkout
>    of the testing commit.
> 4. Update submodules recursively (use force where supports).
> 5. Cleanup all the sources from all files except from repository.
> 
> [1] https://docs.gitlab.com/ee/ci/yaml/README.html#git-clean-flags
> [2] https://docs.gitlab.com/ee/ci/yaml/README.html#git-strategy
> [3] https://docs.gitlab.com/ee/ci/yaml/README.html#git-checkout
> [4] https://docs.gitlab.com/ee/ci/yaml/README.html#git-submodule-strategy
> 
> Follows up #5036

LGTM.

I've checked your patch into 1.10, 2.4, 2.5 and master.

--
Regards, Kirill Yukhin