Tarantool development patches archive
 help / color / mirror / Atom feed
From: Nikita Pettik <korablev@tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] lua: assert on lua_gettop() negative return value
Date: Tue, 21 Jul 2020 18:19:49 +0000	[thread overview]
Message-ID: <20200721181949.GB21662@tarantool.org> (raw)
In-Reply-To: <20200721180730.GK18920@tarantool.org>

On 21 Jul 21:07, Igor Munkin wrote:
> > corresponding sane check with assert is introduced.
> > 
> > Closes #4649
> 
> Side note: I doubt this patch closes #4649. It just adds more
> diagnostics but the doesn't fix the root issue. I guess "Relates to" tag
> is much better here.

Agree.
 

      reply	other threads:[~2020-07-21 18:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 11:05 Ilya Kosarev
2020-07-21 11:54 ` Nikita Pettik
2020-07-21 12:12   ` Ilya Kosarev
2020-07-21 18:07 ` Igor Munkin
2020-07-21 18:19   ` Nikita Pettik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200721181949.GB21662@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=imun@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2] lua: assert on lua_gettop() negative return value' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox